You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/22 07:31:07 UTC

[GitHub] [flink] wangyang0918 removed a comment on pull request #13644: [FLINK-19542][k8s]Implement LeaderElectionService and LeaderRetrievalService based on Kubernetes API

wangyang0918 removed a comment on pull request #13644:
URL: https://github.com/apache/flink/pull/13644#issuecomment-713591200


   @tillrohrmann I have gone though all your comments and will update the PR soon. Just two quick points need to confirm with you.
   
   * Do you think we should not handle the externally deletion/update? For example, a Flink cluster with HA configured is running, some user delete/update the ConfigMap via `kubectl`. If it is yes, I will remove the operations in `KubernetesLeaderElectionService#Watcher`. And change some "ConfigMap not exists" behavior.
   * I am afraid it is hard to use a real K8s server in the UT because it is not very easy to start a `minikube`. I will try to add the unit tests for the contract testing now and leave the real cluster test in E2E test implementation. Does it make sense?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org