You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/21 17:20:21 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #13676: ARROW-17107: [Java] Fix variable-width vectors in integration JSON writer

lidavidm commented on code in PR #13676:
URL: https://github.com/apache/arrow/pull/13676#discussion_r926929036


##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileWriter.java:
##########
@@ -83,8 +84,10 @@
 import com.fasterxml.jackson.databind.MappingJsonFactory;
 
 /**
- * A writer that converts binary Vectors into a JSON format suitable
+ * A writer that converts binary Vectors into an <em>internal, unstable</em> JSON format suitable

Review Comment:
   Integration tests are run via a binary, not via JUnit, so they need to end up in something that gets compiled into a JAR. (Also I'd be a little hesitant to break compatibility immediately here.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org