You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/02 10:56:11 UTC
[GitHub] [pulsar] zymap opened a new pull request #8784: Enable spotbugs check in module package management service
zymap opened a new pull request #8784:
URL: https://github.com/apache/pulsar/pull/8784
---
*Motivation*
Enable spotbugs checks in the module package management service.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8784: Enable spotbugs check in module package management service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8784:
URL: https://github.com/apache/pulsar/pull/8784#issuecomment-737577954
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #8784: Enable spotbugs check in module package management service
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #8784:
URL: https://github.com/apache/pulsar/pull/8784#discussion_r534627336
##########
File path: pulsar-package-management/core/pom.xml
##########
@@ -48,4 +48,16 @@
<artifactId>commons-lang3</artifactId>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <configuration>
+ <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
Review comment:
We are using this file for the exclude filter in the module core: https://github.com/apache/pulsar/pull/8784/files#diff-2ece31f925717628e3a3b606d38970a684b39b9e37f15d90fde5cea381420b02
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8784: Enable spotbugs check in module package management service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8784:
URL: https://github.com/apache/pulsar/pull/8784#issuecomment-737597157
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8784: Enable spotbugs check in module package management service
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8784:
URL: https://github.com/apache/pulsar/pull/8784
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8784: Enable spotbugs check in module package management service
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #8784:
URL: https://github.com/apache/pulsar/pull/8784#discussion_r534625232
##########
File path: pulsar-package-management/core/pom.xml
##########
@@ -48,4 +48,16 @@
<artifactId>commons-lang3</artifactId>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <configuration>
+ <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
Review comment:
```suggestion
<excludeFilterFile>${basedir}/src/main/resources/findbugs-exclude.xml</excludeFilterFile>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8784: Enable spotbugs check in module package management service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8784:
URL: https://github.com/apache/pulsar/pull/8784#issuecomment-737588477
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #8784: Enable spotbugs check in module package management service
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #8784:
URL: https://github.com/apache/pulsar/pull/8784#discussion_r534627336
##########
File path: pulsar-package-management/core/pom.xml
##########
@@ -48,4 +48,16 @@
<artifactId>commons-lang3</artifactId>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <configuration>
+ <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
Review comment:
We are using this file for the exclude filter: https://github.com/apache/pulsar/pull/8784/files#diff-2ece31f925717628e3a3b606d38970a684b39b9e37f15d90fde5cea381420b02
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org