[GitHub] [incubator-pegasus] hycdong commented on a change in pull request #698: feat(split): gc useless data after partition split

[GitBox <gi...@apache.org>]

hycdong commented on a change in pull request #698:
URL: https://github.com/apache/incubator-pegasus/pull/698#discussion_r598578204



##########
File path: src/base/pegasus_const.h
##########
@@ -62,4 +62,6 @@ extern const std::string PEGASUS_CLUSTER_SECTION_NAME;
 extern const std::string ROCKSDB_ENV_SLOW_QUERY_THRESHOLD;
 
 extern const std::string ROCKSDB_ITERATION_THRESHOLD_TIME_MS;
+
+extern const std::string SPLIT_VALIDATE_PARTITION_HASH;

Review comment:
       Actually, the app envs is called `replica.split.validate_partition_hash`, so I rename all `check_partition_hash` into `validate_partition_hash`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org