[jira] [Commented] (CALCITE-1243) max_row_count in protobuf Requests should be signed int

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294061#comment-15294061 ] 

Julian Hyde commented on CALCITE-1243:
--------------------------------------

I saw you marked a method Deprecated. Generally we indicate with a comment when the method will be removed (usually "to be removed before 2.0"). Of course people will still complain.

If you don't think we will ever be able to remove it, I wouldn't bother marking it deprecated.

> max_row_count in protobuf Requests should be signed int
> -------------------------------------------------------
>
>                 Key: CALCITE-1243
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1243
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Duo Xu
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: avatica-1.8.0
>
>
> Looking at the source code, the maxRowCount is signed. And based on the code comments,
>  /** Creates a result set with maxRowCount.
>    *
>    * <p>If {@code maxRowCount} is -2 ({@link JdbcMeta#UNLIMITED_COUNT}),
>    * returns an unlimited number of rows in a single frame; any other
>    * negative value (typically -1) returns an unlimited number of rows
>    * in frames of the default frame size. */
> we can pass -2 to return all the rows in a single batch. But the proto file define this parameter as unsigned. We need to make it consistent with the internal code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)