You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/28 19:12:49 UTC

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549457200



##########
File path: maven-resolver-impl/pom.xml
##########
@@ -49,6 +49,10 @@
       <groupId>org.apache.maven.resolver</groupId>
       <artifactId>maven-resolver-spi</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.apache.maven.resolver</groupId>
+      <artifactId>maven-resolver-named</artifactId>

Review comment:
       "synccontext" exists in resolver-api (SyncContext) and resolver-spi (SyncContextFactory). While I agree that name maven-resolver-named is misleading, it has none of those two contained. What about maven-resolver-named-locks? It was my initial idea, but abstained as then maven-resolver-named-locks-redisson would be unusually long artifact ID...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org