[GitHub] [superset] eschutho commented on a diff in pull request #20015: feat: add new enums for datasource types

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #20015:
URL: https://github.com/apache/superset/pull/20015#discussion_r869760013


##########
superset/utils/core.py:
##########
@@ -174,8 +174,16 @@ class GenericDataType(IntEnum):
     # ROW = 7
 
 
+class DatasourceType(Enum):

Review Comment:
   you're going to want to inherit from (str, Enum) so that you can show the string representation later. 



##########
superset/utils/core.py:
##########
@@ -174,8 +174,16 @@ class GenericDataType(IntEnum):
     # ROW = 7
 
 
+class DatasourceType(Enum):

Review Comment:
   you're going to want to inherit from (str, Enum) so that you can show the string representation later. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org