You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by dr...@apache.org on 2008/06/11 03:03:10 UTC
svn commit: r666457 -
/incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl
Author: dreiss
Date: Tue Jun 10 18:03:10 2008
New Revision: 666457
URL: http://svn.apache.org/viewvc?rev=666457&view=rev
Log:
Remove another TODO - no need to set "id" field of stop markers
Test plan: tested on our price service
Modified:
incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl
Modified: incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl?rev=666457&r1=666456&r2=666457&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl (original)
+++ incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl Tue Jun 10 18:03:10 2008
@@ -190,8 +190,7 @@
read(This, field_begin) ->
case read(This, byte) of
{ok, Type = ?tType_STOP} ->
- #protocol_field_begin{type = Type,
- id = 0}; % TODO(todd) 0 or undefined?
+ #protocol_field_begin{type = Type};
{ok, Type} ->
{ok, Id} = read(This, i16),
#protocol_field_begin{type = Type,