[GitHub] [pinot] npawar commented on a diff in pull request #9424: refactor LLRealtimeSegmentDataManager

[GitBox <gi...@apache.org>]

npawar commented on code in PR #9424:
URL: https://github.com/apache/pinot/pull/9424#discussion_r976845348


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1524,12 +1519,10 @@ private void recreateStreamConsumer(String reason) {
   /**
    * Creates a new stream metadata provider
    */
-  private void makeStreamMetadataProvider(String reason) {
-    if (_streamMetadataProvider != null) {
-      closeStreamMetadataProvider();
-    }
-    _segmentLogger.info("Creating new stream metadata provider, reason: {}", reason);
-    _streamMetadataProvider = _streamConsumerFactory.createStreamMetadataProvider(_clientId);
+  private void createPartitionMetadataProvider(String reason) {
+    closeStreamMetadataProvider();

Review Comment:
   nit: s/_streamMetadataProvider/_partitionMetadataProvider and s/closeStreamMetadataProvider/closePartitionMetadataProvider ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org