[GitHub] [airflow] dakshin-k commented on a diff in pull request #26949: Add type hints for EMR hook

[GitBox <gi...@apache.org>]

dakshin-k commented on code in PR #26949:
URL: https://github.com/apache/airflow/pull/26949#discussion_r990779738


##########
airflow/providers/amazon/aws/hooks/emr.py:
##########
@@ -118,13 +128,13 @@ def create_job_flow(self, job_flow_overrides: dict[str, Any]) -> dict[str, Any]:
                         stacklevel=2,
                     )
                 config = emr_conn.extra_dejson.copy()
-        config.update(job_flow_overrides)
+        config.update(**job_flow_overrides)

Review Comment:
   The IDE threw a type error at this line once I added a type hint for `job_flow_overrides` - Prefixing the `**` removed it.
   
   I believe this shouldn't be a breaking change because the tests still pass, thought I'd explicitly point it out as I'd like a second set of eyes on this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org