[jira] [Commented] (NIFI-3931) putSftp process port property should support for expression language

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071633#comment-16071633 ] 

ASF GitHub Bot commented on NIFI-3931:
--------------------------------------

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/1968

    NIFI-3931 - Added EL to properties in SFTP transfer

    The properties are already evaluated against EL. Also added an
    integration test that is failing without the change.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi NIFI-3931

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1968
    
----
commit bdbfdfa21b1188efba2e2806c9e7381e865a553a
Author: Pierre Villard <pi...@gmail.com>
Date:   2017-07-02T13:24:17Z

    NIFI-3931 - Added EL to properties in SFTP transfer
    
    The properties are already evaluated against EL. Also added an
    integration test that is failing without the change.

----


> putSftp process port property should support for expression language
> --------------------------------------------------------------------
>
>                 Key: NIFI-3931
>                 URL: https://issues.apache.org/jira/browse/NIFI-3931
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Cheng Chin Tat
>            Priority: Minor
>              Labels: easyfix
>
> PutSftp Processor port property should support for expression language so that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)