You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/11 14:24:28 UTC
[GitHub] [airflow] potiuk opened a new pull request, #24390: Revert "Remove custom signal handling in Triggerer (#23274)"
potiuk opened a new pull request, #24390:
URL: https://github.com/apache/airflow/pull/24390
This reverts commit 6bdbed6c43df3c5473b168a75c50e0139cc13e88.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24390: Revert "Remove custom signal handling in Triggerer (#23274)"
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24390:
URL: https://github.com/apache/airflow/pull/24390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24390: Revert "Remove custom signal handling in Triggerer (#23274)"
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24390:
URL: https://github.com/apache/airflow/pull/24390#issuecomment-1154098057
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #24390: Revert "Remove custom signal handling in Triggerer (#23274)"
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #24390:
URL: https://github.com/apache/airflow/pull/24390#issuecomment-1153783165
I’m deferring this to Daniel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24390: Revert "Remove custom signal handling in Triggerer (#23274)"
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24390:
URL: https://github.com/apache/airflow/pull/24390#issuecomment-1152937574
@dstandish Seems that the signal handling did not finally fix the problem (i observed it happening after) and it broke stoping of Triggerer jobs so we have to look further.
Reverting it and reopening the original issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org