You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Stefan Seelmann (JIRA)" <ji...@apache.org> on 2007/06/04 23:54:26 UTC

[jira] Created: (DIRSTUDIO-123) Refactor IConnection interface and Connection class

Refactor IConnection interface and Connection class
---------------------------------------------------

                 Key: DIRSTUDIO-123
                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-123
             Project: Directory Studio
          Issue Type: Improvement
          Components: ldapstudio-browser
    Affects Versions: 0.8.0
            Reporter: Stefan Seelmann
            Priority: Critical


The IConnection interface and the Connection class (and its dependent classes) needs to be refactored:
- They are just too big: The IConnection interface defines 65 methods, the Connection class has more than 1000 LOC and no line of Javadoc :-(
- The procedure of opening a connection (connect, bind, load RootDSE, cache/refresh schema, load base entries) is just horrible
- The Connection class uses LDIF as an interface between the browser classes and the JNDI layer to retrieve information from the directory or to commit modifications. This causes heavy CPU consumption and slows down mass operations.
- In order to support new features lik strong authentication with SASL, extended operations and controls we also have to extend the IConnection interface.

I will create an confluence page that shows the current design. It would be cool if we could discuss the needed requirements and improve the design.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSTUDIO-123) Refactor IConnection interface and Connection class

Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSTUDIO-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501484 ] 

Stefan Seelmann commented on DIRSTUDIO-123:
-------------------------------------------

Thanks, very good point PAM.

> Refactor IConnection interface and Connection class
> ---------------------------------------------------
>
>                 Key: DIRSTUDIO-123
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-123
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-browser
>    Affects Versions: 0.8.0
>            Reporter: Stefan Seelmann
>            Priority: Critical
>
> The IConnection interface and the Connection class (and its dependent classes) needs to be refactored:
> - They are just too big: The IConnection interface defines 65 methods, the Connection class has more than 1000 LOC and no line of Javadoc :-(
> - The procedure of opening a connection (connect, bind, load RootDSE, cache/refresh schema, load base entries) is just horrible
> - The Connection class uses LDIF as an interface between the browser classes and the JNDI layer to retrieve information from the directory or to commit modifications. This causes heavy CPU consumption and slows down mass operations.
> - In order to support new features lik strong authentication with SASL, extended operations and controls we also have to extend the IConnection interface.
> I will create an confluence page that shows the current design. It would be cool if we could discuss the needed requirements and improve the design.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRSTUDIO-123) Refactor IConnection interface and Connection class

Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSTUDIO-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pierre-Arnaud Marcelot closed DIRSTUDIO-123.
--------------------------------------------


Version 1.1.0 has been released.
Closing this issue.

> Refactor IConnection interface and Connection class
> ---------------------------------------------------
>
>                 Key: DIRSTUDIO-123
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-123
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>    Affects Versions: 0.8.0, 0.8.1, 0.8.2, 1.0.0
>            Reporter: Stefan Seelmann
>            Assignee: Stefan Seelmann
>            Priority: Critical
>             Fix For: 1.1.0
>
>
> The IConnection interface and the Connection class (and its dependent classes) needs to be refactored:
> - They are just too big: The IConnection interface defines 65 methods, the Connection class has more than 1000 LOC and no line of Javadoc :-(
> - The procedure of opening a connection (connect, bind, load RootDSE, cache/refresh schema, load base entries) is just horrible
> - The Connection class uses LDIF as an interface between the browser classes and the JNDI layer to retrieve information from the directory or to commit modifications. This causes heavy CPU consumption and slows down mass operations.
> - In order to support new features lik strong authentication with SASL, extended operations and controls we also have to extend the IConnection interface.
> I will create an confluence page that shows the current design. It would be cool if we could discuss the needed requirements and improve the design.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSTUDIO-123) Refactor IConnection interface and Connection class

Posted by "Christine Koppelt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSTUDIO-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502877 ] 

Christine Koppelt commented on DIRSTUDIO-123:
---------------------------------------------

As Stefan and Enrique offered their help i would like to start implementing the SASL authentication after the
refactoring has been finished.

> Refactor IConnection interface and Connection class
> ---------------------------------------------------
>
>                 Key: DIRSTUDIO-123
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-123
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-browser
>    Affects Versions: 0.8.0
>            Reporter: Stefan Seelmann
>            Priority: Critical
>
> The IConnection interface and the Connection class (and its dependent classes) needs to be refactored:
> - They are just too big: The IConnection interface defines 65 methods, the Connection class has more than 1000 LOC and no line of Javadoc :-(
> - The procedure of opening a connection (connect, bind, load RootDSE, cache/refresh schema, load base entries) is just horrible
> - The Connection class uses LDIF as an interface between the browser classes and the JNDI layer to retrieve information from the directory or to commit modifications. This causes heavy CPU consumption and slows down mass operations.
> - In order to support new features lik strong authentication with SASL, extended operations and controls we also have to extend the IConnection interface.
> I will create an confluence page that shows the current design. It would be cool if we could discuss the needed requirements and improve the design.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSTUDIO-123) Refactor IConnection interface and Connection class

Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSTUDIO-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Seelmann updated DIRSTUDIO-123:
--------------------------------------

        Fix Version/s: 1.1.0
             Assignee: Stefan Seelmann
    Affects Version/s: 0.8.1
                       0.8.2
                       1.0.0

> Refactor IConnection interface and Connection class
> ---------------------------------------------------
>
>                 Key: DIRSTUDIO-123
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-123
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>    Affects Versions: 0.8.0, 0.8.1, 0.8.2, 1.0.0
>            Reporter: Stefan Seelmann
>            Assignee: Stefan Seelmann
>            Priority: Critical
>             Fix For: 1.1.0
>
>
> The IConnection interface and the Connection class (and its dependent classes) needs to be refactored:
> - They are just too big: The IConnection interface defines 65 methods, the Connection class has more than 1000 LOC and no line of Javadoc :-(
> - The procedure of opening a connection (connect, bind, load RootDSE, cache/refresh schema, load base entries) is just horrible
> - The Connection class uses LDIF as an interface between the browser classes and the JNDI layer to retrieve information from the directory or to commit modifications. This causes heavy CPU consumption and slows down mass operations.
> - In order to support new features lik strong authentication with SASL, extended operations and controls we also have to extend the IConnection interface.
> I will create an confluence page that shows the current design. It would be cool if we could discuss the needed requirements and improve the design.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSTUDIO-123) Refactor IConnection interface and Connection class

Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSTUDIO-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501480 ] 

Pierre-Arnaud Marcelot commented on DIRSTUDIO-123:
--------------------------------------------------

I think, it could be a good thing to build a separate plugin for the connections handling.
This way, connections defined in this plugin can be shared by several plugins: the LDAP Browser plugin of course, but the dynamic online schema editor plugin also, etc.

Since you plan to refactor this class and interface, it could be the good timing to build such a plugin.

> Refactor IConnection interface and Connection class
> ---------------------------------------------------
>
>                 Key: DIRSTUDIO-123
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-123
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: ldapstudio-browser
>    Affects Versions: 0.8.0
>            Reporter: Stefan Seelmann
>            Priority: Critical
>
> The IConnection interface and the Connection class (and its dependent classes) needs to be refactored:
> - They are just too big: The IConnection interface defines 65 methods, the Connection class has more than 1000 LOC and no line of Javadoc :-(
> - The procedure of opening a connection (connect, bind, load RootDSE, cache/refresh schema, load base entries) is just horrible
> - The Connection class uses LDIF as an interface between the browser classes and the JNDI layer to retrieve information from the directory or to commit modifications. This causes heavy CPU consumption and slows down mass operations.
> - In order to support new features lik strong authentication with SASL, extended operations and controls we also have to extend the IConnection interface.
> I will create an confluence page that shows the current design. It would be cool if we could discuss the needed requirements and improve the design.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSTUDIO-123) Refactor IConnection interface and Connection class

Posted by "Ersin Er (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSTUDIO-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501395 ] 

Ersin Er commented on DIRSTUDIO-123:
------------------------------------

I am interested. So, where is the page? :-)

> Refactor IConnection interface and Connection class
> ---------------------------------------------------
>
>                 Key: DIRSTUDIO-123
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-123
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: ldapstudio-browser
>    Affects Versions: 0.8.0
>            Reporter: Stefan Seelmann
>            Priority: Critical
>
> The IConnection interface and the Connection class (and its dependent classes) needs to be refactored:
> - They are just too big: The IConnection interface defines 65 methods, the Connection class has more than 1000 LOC and no line of Javadoc :-(
> - The procedure of opening a connection (connect, bind, load RootDSE, cache/refresh schema, load base entries) is just horrible
> - The Connection class uses LDIF as an interface between the browser classes and the JNDI layer to retrieve information from the directory or to commit modifications. This causes heavy CPU consumption and slows down mass operations.
> - In order to support new features lik strong authentication with SASL, extended operations and controls we also have to extend the IConnection interface.
> I will create an confluence page that shows the current design. It would be cool if we could discuss the needed requirements and improve the design.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSTUDIO-123) Refactor IConnection interface and Connection class

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSTUDIO-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501392 ] 

Emmanuel Lecharny commented on DIRSTUDIO-123:
---------------------------------------------

Just perfect ! We are waiting for tye confluence page :)

Thanks Stefan

> Refactor IConnection interface and Connection class
> ---------------------------------------------------
>
>                 Key: DIRSTUDIO-123
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-123
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: ldapstudio-browser
>    Affects Versions: 0.8.0
>            Reporter: Stefan Seelmann
>            Priority: Critical
>
> The IConnection interface and the Connection class (and its dependent classes) needs to be refactored:
> - They are just too big: The IConnection interface defines 65 methods, the Connection class has more than 1000 LOC and no line of Javadoc :-(
> - The procedure of opening a connection (connect, bind, load RootDSE, cache/refresh schema, load base entries) is just horrible
> - The Connection class uses LDIF as an interface between the browser classes and the JNDI layer to retrieve information from the directory or to commit modifications. This causes heavy CPU consumption and slows down mass operations.
> - In order to support new features lik strong authentication with SASL, extended operations and controls we also have to extend the IConnection interface.
> I will create an confluence page that shows the current design. It would be cool if we could discuss the needed requirements and improve the design.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DIRSTUDIO-123) Refactor IConnection interface and Connection class

Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSTUDIO-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Seelmann resolved DIRSTUDIO-123.
---------------------------------------

    Resolution: Fixed

- Created two plugins dedicated for conntections: studio-connection-core and studio-connection-ui
- Moved connection handling and modification logs to the studio-connection-core plugin
- Moved search and modify operations to the job classes
- Removed LDIF layer


> Refactor IConnection interface and Connection class
> ---------------------------------------------------
>
>                 Key: DIRSTUDIO-123
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-123
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>    Affects Versions: 0.8.0, 0.8.1, 0.8.2, 1.0.0
>            Reporter: Stefan Seelmann
>            Assignee: Stefan Seelmann
>            Priority: Critical
>             Fix For: 1.1.0
>
>
> The IConnection interface and the Connection class (and its dependent classes) needs to be refactored:
> - They are just too big: The IConnection interface defines 65 methods, the Connection class has more than 1000 LOC and no line of Javadoc :-(
> - The procedure of opening a connection (connect, bind, load RootDSE, cache/refresh schema, load base entries) is just horrible
> - The Connection class uses LDIF as an interface between the browser classes and the JNDI layer to retrieve information from the directory or to commit modifications. This causes heavy CPU consumption and slows down mass operations.
> - In order to support new features lik strong authentication with SASL, extended operations and controls we also have to extend the IConnection interface.
> I will create an confluence page that shows the current design. It would be cool if we could discuss the needed requirements and improve the design.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.