You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/04 08:59:20 UTC
[GitHub] [arrow] AlenkaF opened a new pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
AlenkaF opened a new pull request #11602:
URL: https://github.com/apache/arrow/pull/11602
Add note to C++ and Python dev doc suggesting the use of `-DARROW_INSTALL_NAME_RPATH=OFF` when doing development on MacOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-961687325
> One thing I am wondering is to what extent this recommendation only applies to when not using conda? Or setting this cmake variable also can't hurt when not strictly needed?
I wouldn't know that, @lidavidm what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cmpadden commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
cmpadden commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-1033794190
@edponce -- interesting. I would be curious to know how your environment differs from mine. I am also using an M1 Mac running Monterrey. Did you install Python via Homebrew, and use a `virtualenv` with `pip`?
The full set of commands I ran can be found in this gist:
https://gist.github.com/cmpadden/3b60b604b2457ceeeed3024bfc2950c0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-961871665
It only has an effect on MacOS and is a no-op otherwise. I think it shouldn't hurt - when turned off, then the dynamic linker will search for libarrow in the install location. When turned on (which appears to be the default in CMake), the dynamic linker will search for libarrow in the rpath, which is a set of search paths (that appear to default to system directories). So for development, I think it makes more sense to disable this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-1037946558
> @xhochy What is your opinion on this?
I don't use that option as I always `ninja install` during my build/develop process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-1033435876
@wjones127 I think it would make sense to add the flag to the CMakePresets also, yes. Will make the change, if there is no opinion to contradict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-1033564063
@edponce thank you for the information, it is good to know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-960567305
https://issues.apache.org/jira/browse/ARROW-14570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-961687325
> One thing I am wondering is to what extent this recommendation only applies to when not using conda? Or setting this cmake variable also can't hurt when not strictly needed?
I wouldn't know that, @lidavidm what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-1033431072
@cmpadden thank you for commenting! I think it would be nice to have a likely error message included. Will add it to the proposed PR and see what others think about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
wjones127 commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-987224174
If we go forward with this, could we also add `"ARROW_INSTALL_NAME_RPATH": "OFF"` to the `base-debug` CMakePresets config?
https://github.com/apache/arrow/blob/85b276dd13512d6676a0bc2dc703a0f9b6934236/cpp/CMakePresets.json#L18-L25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-1037946558
> @xhochy What is your opinion on this?
I don't use that option as I always `ninja install` during my build/develop process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-961687325
> One thing I am wondering is to what extent this recommendation only applies to when not using conda? Or setting this cmake variable also can't hurt when not strictly needed?
I wouldn't know that, @lidavidm what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-961871665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-960572085
One thing I am wondering is to what extent this recommendation only applies to when not using conda?
Or setting this cmake variable also can't hurt when not strictly needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] edponce commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
edponce commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-1033527029
Up to now, I have been able to successfully build/run Arrow (C++, Python, and R) on M1 MacOS Monterrey without major issues and with `ARROW_INSTALL_NAME_RPATH=ON`. Obviously, this does not proves that the described linker errors cannot be resolved another way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cmpadden commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
cmpadden commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-1033054411
I'm glad I stumbled on this PR as I was running into this issue while following the _Python Development_ guide.
In addition to recommending the use of `-DARROW_INSTALL_NAME_RPATH=OFF` for development on MacOS, do you think it would be beneficial to present the user with a likely error message that is a result of not setting this option? See:
```
E Reason: tried: '/opt/homebrew/lib/libarrow.800.dylib' (no such file), '/opt/homebrew/lib/libarrow.800.dylib' (no such file), '/usr/local/lib/libarrow.800.dylib' (no such file), '/usr/lib/libarrow.800.dylib' (no such file)
```
Or would this be too verbose and user-specific for the docs? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11602: ARROW-14570: [Docs][C++][Python] Suggest using -DARROW_INSTALL_NAME_RPATH=OFF on MacOS
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11602:
URL: https://github.com/apache/arrow/pull/11602#issuecomment-963259366
@xhochy What is your opinion on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org