[jira] [Commented] (SAMZA-115) Allow metric group name overrides BlockingEnvelopeMap

["Jakob Homan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863926#comment-13863926 ] 

Jakob Homan commented on SAMZA-115:
-----------------------------------

+1

> Allow metric group name overrides BlockingEnvelopeMap
> -----------------------------------------------------
>
>                 Key: SAMZA-115
>                 URL: https://issues.apache.org/jira/browse/SAMZA-115
>             Project: Samza
>          Issue Type: Bug
>          Components: container, metrics
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Chris Riccomini
>              Labels: newbie
>         Attachments: SAMZA-115.0.patch, blocking-envelope-map-metric-name.png
>
>
> BlockingEnvelopeMap currently hard-codes the metric group as this.getClass().getName(). This is generally OK, but there are occasions where we might want to override it (KafkaSystemConsumer being one of them).
> I think we should update the BlockingEnvelopeMap to take a parameter for the metrics name, and update KafkaSystemConsumer to use classOf[KafkaSystemConsumerMetrics].getName().



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)