You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/19 22:15:06 UTC

[GitHub] [arrow] westonpace commented on pull request #13487: ARROW-16945: [C++] Add new scalar compute function for 32-bit hashing

westonpace commented on PR #13487:
URL: https://github.com/apache/arrow/pull/13487#issuecomment-1189604651

   > I'd add that non-random but likely selections should also show a nice hash distribution. Including:
   > The implementations from arrow/util/hashing.h try to satisfy those requirements, btw, so you could reuse them.
   
   It would be great, by the way, to have benchmarks of the two hashing utilities we have.  I believe the utilities we have in `key_hash.h` trade off some distribution performance in favor of runtime performance when compared with the utilities in `hashing.h`.  It would be nice to have some objective measures of this tradeoff.
   
   Also, can we expand in the function doc that these hashes are not suitable for cryptographic purposes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org