[jira] [Commented] (BEAM-1938) Side Inputs should be part of the expanded inputs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965072#comment-15965072 ] 

ASF GitHub Bot commented on BEAM-1938:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2501

    [BEAM-1938] Update Signature of PTransformOverrideFactory

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    This enables replacements to be reobtained with the entire transform
    that is being replaced.
    
    This is required when Side Inputs are part of the input of the
    PTransform Application, as PTransforms are not applied to their side
    inputs.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam override_factory_entire_context

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2501
    
----
commit caf32a9742fabf8e95631e018afa6f981d6f5249
Author: Thomas Groh <tg...@google.com>
Date:   2017-03-29T22:23:21Z

    Update Signature of PTransformOverrideFactory
    
    This enables replacements to be reobtained with the entire transform
    that is being replaced.
    
    This is required when Side Inputs are part of the input of the
    PTransform Application, as PTransforms are not applied to their side
    inputs.

----


> Side Inputs should be part of the expanded inputs
> -------------------------------------------------
>
>                 Key: BEAM-1938
>                 URL: https://issues.apache.org/jira/browse/BEAM-1938
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> Required for the Java SDK to construct the runner API graphs without inspecting arbitrary transforms.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)