You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/05 17:25:50 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #912: testing/ostest: Don't include arch/tls.h

xiaoxiang781216 opened a new pull request #912:
URL: https://github.com/apache/incubator-nuttx-apps/pull/912


   ## Summary
   since it doesn't exist any more since PR https://github.com/apache/incubator-nuttx/pull/4941
   
   ## Impact
   No
   
   ## Testing
   Pass CI and ostest
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] gustavonihei commented on a change in pull request #912: testing/ostest: Don't include arch/tls.h

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #912:
URL: https://github.com/apache/incubator-nuttx-apps/pull/912#discussion_r762659534



##########
File path: testing/ostest/tls.c
##########
@@ -35,8 +35,6 @@
 
 #if CONFIG_TLS_NELEM > 0
 
-#include <arch/tls.h>

Review comment:
       Not needed because `include/nuttx/tls.h` already includes it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] gustavonihei merged pull request #912: testing/ostest: Don't include arch/tls.h

Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #912:
URL: https://github.com/apache/incubator-nuttx-apps/pull/912


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #912: testing/ostest: Don't include arch/tls.h

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #912:
URL: https://github.com/apache/incubator-nuttx-apps/pull/912#discussion_r762595720



##########
File path: testing/ostest/tls.c
##########
@@ -35,8 +35,6 @@
 
 #if CONFIG_TLS_NELEM > 0
 
-#include <arch/tls.h>

Review comment:
       Don't we need to include `<nuttx/arch.h>` now?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org