You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sachingoel0101 <gi...@git.apache.org> on 2015/07/30 10:25:56 UTC
[GitHub] flink pull request: [FLINK-2238][api]Add env.fromCollection(set) m...
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/956
[FLINK-2238][api]Add env.fromCollection(set) method to scala api
Used the same technique as in env.fromCollection(Seq) to first convert the data to a Java Collection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sachingoel0101/flink flink-2238
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/956.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #956
----
commit 7a2ca2987ffc890032fd9c61ac0800b92baf5cf8
Author: Sachin Goel <sa...@gmail.com>
Date: 2015-07-30T08:24:26Z
[FLINK-2238][api]Added env.fromCollection(set) method to scala api
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2238][scala api]Add env.fromCollection(...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/956#issuecomment-127186044
Alright, I reverted the commit for the release-0.9 branch and created a [wiki page](https://cwiki.apache.org/confluence/display/FLINK/0.10+Release) for issues relates to the 0.10 release including API-breaking changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2238][scala api]Add env.fromCollection(...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/956#issuecomment-126283207
Thanks for the update, @sachingoel0101!
Good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2238][scala api]Add env.fromCollection(...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/956#issuecomment-126509831
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2238][scala api]Add env.fromCollection(...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/956
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2238][scala api]Add env.fromCollection(...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/956#issuecomment-126257935
Ah. Yes. That does make more sense. :+1:
Updating now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2238][scala api]Add env.fromCollection(...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/956#issuecomment-126253269
Hi @sachingoel0101,
thanks for the PR!
I think we don't need a new method specifically for Sets. It is sufficient to change the parameter type of the first `fromCollection` from `Seq` to `Iterable` to support `Set` (and other non-Seq collections).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2238][scala api]Add env.fromCollection(...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/956#issuecomment-126947195
Damn, that's on me. :-/
I'll revert the commit for the 0.9 branch and recommit for 0.10 with corrected commit message.
Is there already an API change list for 0.10 or do we need to start one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2238][scala api]Add env.fromCollection(...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/956#issuecomment-127042179
No problem, it happens ;-)
Good idea to put it in 0.10 but not in 0.9.1.
I think there is no API change list yet. Should we start one in the wiki?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2238][scala api]Add env.fromCollection(...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/956#issuecomment-126916758
This change was actually API breaking (binary compatibility). It should actually be tagged like that.
For the release 0.10, there should also be a list of what was broken.
Who takes care of that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---