You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Udo Kohlmeyer <uk...@gmail.com> on 2016/08/18 23:29:00 UTC
Re: Review Request 51227: GEODE-420: Locator SSL
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51227/
-----------------------------------------------------------
(Updated Aug. 18, 2016, 11:28 p.m.)
Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
Repository: geode
Description
-------
* Removal of legacy/deprecate previous ssl-* properties
* Deprecation of current <component>-ssl-* properties
* Moving of SocketCreator and SocketCloser to the com.gemstone.gemfire.internal.net package
* Addition of an ExtendedAliasKeyManager to manage keystores with many keys and aliases
* Addition of locator ssl properties
* Addition of SocketCreatorFactory
* Addition of SSLConfigFactory
* Addition of JMXMBeanDUnitTest
* Addition of SSLEnabledComponent Enum
* Ciphers and Protocols are stored as String[] instead of previous legacy String
* TCPClient is now instance rather than Singleton
Diffs
-----
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java 3408717
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsQueryAndFEJUnitTest.java 8321caf
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java daa781d
geode-core/src/main/java/com/gemstone/gemfire/admin/DistributedSystemConfig.java 5ef389f
geode-core/src/main/java/com/gemstone/gemfire/admin/GemFireMemberStatus.java 1b544a8
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemConfigImpl.java 517f5a6
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemHealthMonitor.java 54e7de7
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributionLocatorConfigImpl.java 88d939a
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/EnabledManagedEntityController.java ff139c5
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/InetAddressUtil.java 43d8e44
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/ManagedEntityConfigImpl.java 69751e9
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentConfigImpl.java a71c479
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentLauncher.java dfa9ac3
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JServerSocketFactory.java 649038e
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImpl.java 844a775
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionFactoryImpl.java 56449db
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionImpl.java 6ed2912
geode-core/src/main/java/com/gemstone/gemfire/distributed/ConfigurationProperties.java 5c3a282
geode-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java 8795b71
geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 81d874d
geode-core/src/main/java/com/gemstone/gemfire/distributed/SSLEnabledComponents.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java cce482a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java cc544f6
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfig.java 2ff6540
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java fd4743b
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 259f7c2
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 49a4c97
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 46d9610
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 7f8eed6
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/RuntimeDistributionConfigImpl.java c1384c3
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocation.java 0e7430c
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java f5b774f
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java 9f18e62
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 2d8b8e1
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberFactory.java 4328bed
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSUtil.java d489431
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java 6df0c7b
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 9fdbb64
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java 1065214
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 58b794a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGAddress.java 1f97001
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java a119bb5
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/LocatorCancelException.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpClient.java c770238
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java ceb5af8
geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 4d0c5a8
geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 7a8dccd
geode-core/src/main/java/com/gemstone/gemfire/internal/DistributionLocator.java 2549c7a
geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1
geode-core/src/main/java/com/gemstone/gemfire/internal/MigrationClient.java 2c81e90
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCloser.java 8318afa
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java fded3c3
geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/SSLConfig.java 36c553e
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/DistributionLocatorId.java 1459d89
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/FetchHostResponse.java a9712be
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java 17875bf
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ClusterConfigurationLoader.java e362389
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a7bad
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RedundancyLogger.java f7e8621
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/PersistentMemberPattern.java a0e1f0a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java 7422e16
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 6fd4560
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientUpdater.java 26efd4d
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheServerStats.java 658b35e
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/GatewayReceiverCreation.java e76d39a
geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java 443fe78
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLEnabledComponent.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCloser.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreator.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreatorFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatHelper.java b52eaae
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatSampler.java d414d2c
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveWriter.java 027bde1
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java a69f878
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/ConnectionTable.java 3a5eb9f
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java a38244c
geode-core/src/main/java/com/gemstone/gemfire/management/GemFireProperties.java 5f09d7d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JettyHelper.java 42dcd64
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerAdvisee.java 3af34e1
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java 861f51d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java f3c771f
geode-core/src/main/java/com/gemstone/gemfire/management/internal/RestAgent.java e835bab
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/BeanUtilFuncs.java b802648
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java 08260d3
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 7b04c06
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 09a25a6
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/JmxOperationInvoker.java a67cae3
geode-core/src/main/java/com/gemstone/gemfire/memcached/GemFireMemcachedServer.java ba0b479
geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java 6f6ae6d
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java fef2171
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 42bd683
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/CacheServerSSLConnectionDUnitTest.java ee5cc62
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/LocatorLoadBalancingDUnitTest.java 1bc2322
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java 3c05794
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationTestCase.java cc13c48
geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java 1be3b9f
geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java 438c3f7
geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherMemberMXBeanIntegrationTest.java 8c570ac
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 954846f
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java af0c30d
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalIntegrationTest.java faf6d31
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteIntegrationTest.java 8e978e9
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalIntegrationTest.java 1baf48d
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteIntegrationTest.java 6d20673
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionConfigJUnitTest.java 6d6f36d
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java a59262e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/StartupMessageDataJUnitTest.java 6aa4248
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/MembershipJUnitTest.java 9c7180e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/NetViewJUnitTest.java fbc4189
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java d29553c
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocatorRecoveryJUnitTest.java fcf77a0
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerBackwardCompatDUnitTest.java 954aff4
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitTest.java 425b391
geode-core/src/test/java/com/gemstone/gemfire/internal/AbstractConfigJUnitTest.java 400f872
geode-core/src/test/java/com/gemstone/gemfire/internal/JSSESocketJUnitTest.java d0d906a
geode-core/src/test/java/com/gemstone/gemfire/internal/SSLConfigJUnitTest.java c8addf8
geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserJUnitTest.java cc71738
geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserWithWaitJUnitTest.java 0ba41ba
geode-core/src/test/java/com/gemstone/gemfire/internal/net/JSSESocketJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactoryTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserWithWaitJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCreatorFactoryJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/GemFireStatSamplerIntegrationTest.java ff7c34d
geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/SimpleStatSamplerIntegrationTest.java d86b968
geode-core/src/test/java/com/gemstone/gemfire/internal/tcp/ConnectionJUnitTest.java 3a88707
geode-core/src/test/java/com/gemstone/gemfire/management/CacheManagementDUnitTest.java 550a6cb
geode-core/src/test/java/com/gemstone/gemfire/management/JMXMBeanDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 91a6188
geode-core/src/test/java/com/gemstone/gemfire/management/internal/JettyHelperJUnitTest.java 1c66780
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 5720955
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 21cdfbc
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java 6f70e57
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 32cea6a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 7a96adf
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 2691e09
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java 86c61b6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 87a7ab9
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationDUnitTest.java 3c17f9f
geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java c591732
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NetworkUtils.java dec882e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java 686779d
geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb87797
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/excludedClasses.txt ddacf99
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 03288c2
geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKey.jks PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKeyTrust.jks PRE-CREATION
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/testbed/driver/PulseUITest.java 24ba815
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java eeaa069
geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorDiscovery.java 0fd206e
geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java 5f4943d
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractRemoteGatewaySender.java d45d5ef
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java 9fd73e6
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java fd2c0b5
geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java bdd5d71
geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java b35dce9
gradle/java.gradle 36d88dc
Diff: https://reviews.apache.org/r/51227/diff/
Testing
-------
Thanks,
Udo Kohlmeyer
Re: Review Request 51227: GEODE-420: Locator SSL
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51227/#review146223
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/distributed/ConfigurationProperties.java (line 158)
<https://reviews.apache.org/r/51227/#comment212592>
There are a number of deprecated SSL properties in this file that say to use other properties, but those properties are also deprecated an point to the new properties you've added. In order to avoid confusion they should all point to your new properties. See SERVER_SSL_CIPHERS, for instance.
ReviewBoard has really made a mess of your diffs. There are also a large number of formatting changes to wade through. Can you do a walkthrough for us?
- Bruce Schuchardt
On Aug. 18, 2016, 11:30 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51227/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2016, 11:30 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
>
>
> Repository: geode
>
>
> Description
> -------
>
> As per the specification: https://cwiki.apache.org/confluence/display/GEODE/Revised+SSL+properties
>
> * Removal of legacy/deprecate previous ssl-* properties
> * Deprecation of current <component>-ssl-* properties
> * Moving of SocketCreator and SocketCloser to the com.gemstone.gemfire.internal.net package
> * Addition of an ExtendedAliasKeyManager to manage keystores with many keys and aliases
> * Addition of locator ssl properties
> * Addition of SocketCreatorFactory
> * Addition of SSLConfigFactory
> * Addition of JMXMBeanDUnitTest
> * Addition of SSLEnabledComponent Enum
> * Ciphers and Protocols are stored as String[] instead of previous legacy String
> * TCPClient is now instance rather than Singleton
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java 3408717
> geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsQueryAndFEJUnitTest.java 8321caf
> geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java daa781d
> geode-core/src/main/java/com/gemstone/gemfire/admin/DistributedSystemConfig.java 5ef389f
> geode-core/src/main/java/com/gemstone/gemfire/admin/GemFireMemberStatus.java 1b544a8
> geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemConfigImpl.java 517f5a6
> geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemHealthMonitor.java 54e7de7
> geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributionLocatorConfigImpl.java 88d939a
> geode-core/src/main/java/com/gemstone/gemfire/admin/internal/EnabledManagedEntityController.java ff139c5
> geode-core/src/main/java/com/gemstone/gemfire/admin/internal/InetAddressUtil.java 43d8e44
> geode-core/src/main/java/com/gemstone/gemfire/admin/internal/ManagedEntityConfigImpl.java 69751e9
> geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentConfigImpl.java a71c479
> geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentLauncher.java dfa9ac3
> geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JServerSocketFactory.java 649038e
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImpl.java 844a775
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionFactoryImpl.java 56449db
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionImpl.java 6ed2912
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ConfigurationProperties.java 5c3a282
> geode-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java 8795b71
> geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 81d874d
> geode-core/src/main/java/com/gemstone/gemfire/distributed/SSLEnabledComponents.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java cce482a
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java cc544f6
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfig.java 2ff6540
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java fd4743b
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 259f7c2
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 49a4c97
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 46d9610
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 7f8eed6
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/RuntimeDistributionConfigImpl.java c1384c3
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocation.java 0e7430c
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java f5b774f
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java 9f18e62
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 2d8b8e1
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberFactory.java 4328bed
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSUtil.java d489431
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java 6df0c7b
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 9fdbb64
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java 1065214
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 58b794a
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGAddress.java 1f97001
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java a119bb5
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/LocatorCancelException.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpClient.java c770238
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java ceb5af8
> geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 4d0c5a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 7a8dccd
> geode-core/src/main/java/com/gemstone/gemfire/internal/DistributionLocator.java 2549c7a
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1
> geode-core/src/main/java/com/gemstone/gemfire/internal/MigrationClient.java 2c81e90
> geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCloser.java 8318afa
> geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java fded3c3
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f
> geode-core/src/main/java/com/gemstone/gemfire/internal/admin/SSLConfig.java 36c553e
> geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/DistributionLocatorId.java 1459d89
> geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/FetchHostResponse.java a9712be
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java 17875bf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ClusterConfigurationLoader.java e362389
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a7bad
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RedundancyLogger.java f7e8621
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/PersistentMemberPattern.java a0e1f0a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java 7422e16
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 6fd4560
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientUpdater.java 26efd4d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheServerStats.java 658b35e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/GatewayReceiverCreation.java e76d39a
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java 443fe78
> geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactory.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLEnabledComponent.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCloser.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreator.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreatorFactory.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatHelper.java b52eaae
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatSampler.java d414d2c
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveWriter.java 027bde1
> geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java a69f878
> geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/ConnectionTable.java 3a5eb9f
> geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java a38244c
> geode-core/src/main/java/com/gemstone/gemfire/management/GemFireProperties.java 5f09d7d
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/JettyHelper.java 42dcd64
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerAdvisee.java 3af34e1
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java 861f51d
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java f3c771f
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/RestAgent.java e835bab
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/BeanUtilFuncs.java b802648
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java 08260d3
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 7b04c06
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 09a25a6
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/JmxOperationInvoker.java a67cae3
> geode-core/src/main/java/com/gemstone/gemfire/memcached/GemFireMemcachedServer.java ba0b479
> geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java 6f6ae6d
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java fef2171
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 42bd683
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/CacheServerSSLConnectionDUnitTest.java ee5cc62
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/LocatorLoadBalancingDUnitTest.java 1bc2322
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java 3c05794
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationTestCase.java cc13c48
> geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java 1be3b9f
> geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java 438c3f7
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherMemberMXBeanIntegrationTest.java 8c570ac
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 954846f
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java af0c30d
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalIntegrationTest.java faf6d31
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteIntegrationTest.java 8e978e9
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalIntegrationTest.java 1baf48d
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteIntegrationTest.java 6d20673
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionConfigJUnitTest.java 6d6f36d
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java a59262e
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/StartupMessageDataJUnitTest.java 6aa4248
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/MembershipJUnitTest.java 9c7180e
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/NetViewJUnitTest.java fbc4189
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java d29553c
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocatorRecoveryJUnitTest.java fcf77a0
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerBackwardCompatDUnitTest.java 954aff4
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitTest.java 425b391
> geode-core/src/test/java/com/gemstone/gemfire/internal/AbstractConfigJUnitTest.java 400f872
> geode-core/src/test/java/com/gemstone/gemfire/internal/JSSESocketJUnitTest.java d0d906a
> geode-core/src/test/java/com/gemstone/gemfire/internal/SSLConfigJUnitTest.java c8addf8
> geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserJUnitTest.java cc71738
> geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserWithWaitJUnitTest.java 0ba41ba
> geode-core/src/test/java/com/gemstone/gemfire/internal/net/JSSESocketJUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactoryTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserJUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserWithWaitJUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCreatorFactoryJUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/GemFireStatSamplerIntegrationTest.java ff7c34d
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/SimpleStatSamplerIntegrationTest.java d86b968
> geode-core/src/test/java/com/gemstone/gemfire/internal/tcp/ConnectionJUnitTest.java 3a88707
> geode-core/src/test/java/com/gemstone/gemfire/management/CacheManagementDUnitTest.java 550a6cb
> geode-core/src/test/java/com/gemstone/gemfire/management/JMXMBeanDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 91a6188
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/JettyHelperJUnitTest.java 1c66780
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 5720955
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 21cdfbc
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java 6f70e57
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 32cea6a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 7a96adf
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 2691e09
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java 86c61b6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 87a7ab9
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationDUnitTest.java 3c17f9f
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java c591732
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NetworkUtils.java dec882e
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java 686779d
> geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb87797
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/excludedClasses.txt ddacf99
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 03288c2
> geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKey.jks PRE-CREATION
> geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKeyTrust.jks PRE-CREATION
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/testbed/driver/PulseUITest.java 24ba815
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java eeaa069
> geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorDiscovery.java 0fd206e
> geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java 5f4943d
> geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractRemoteGatewaySender.java d45d5ef
> geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java 9fd73e6
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java fd2c0b5
> geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java bdd5d71
> geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java b35dce9
> gradle/java.gradle 36d88dc
>
> Diff: https://reviews.apache.org/r/51227/diff/
>
>
> Testing
> -------
>
> precheckin
> regression testing to follow
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 51227: GEODE-420: Locator SSL
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51227/
-----------------------------------------------------------
(Updated Aug. 22, 2016, 5:43 p.m.)
Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
Changes
-------
Rollback some checkAttribute changes
Repository: geode
Description
-------
As per the specification: https://cwiki.apache.org/confluence/display/GEODE/Revised+SSL+properties
* Removal of legacy/deprecate previous ssl-* properties
* Deprecation of current <component>-ssl-* properties
* Moving of SocketCreator and SocketCloser to the com.gemstone.gemfire.internal.net package
* Addition of an ExtendedAliasKeyManager to manage keystores with many keys and aliases
* Addition of locator ssl properties
* Addition of SocketCreatorFactory
* Addition of SSLConfigFactory
* Addition of JMXMBeanDUnitTest
* Addition of SSLEnabledComponent Enum
* Ciphers and Protocols are stored as String[] instead of previous legacy String
* TCPClient is now instance rather than Singleton
Diffs (updated)
-----
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java 3408717
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsQueryAndFEJUnitTest.java 8321caf
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java daa781d
geode-core/src/main/java/com/gemstone/gemfire/admin/DistributedSystemConfig.java 5ef389f
geode-core/src/main/java/com/gemstone/gemfire/admin/GemFireMemberStatus.java 1b544a8
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemConfigImpl.java 517f5a6
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemHealthMonitor.java 54e7de7
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributionLocatorConfigImpl.java 88d939a
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/EnabledManagedEntityController.java ff139c5
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/InetAddressUtil.java 43d8e44
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/ManagedEntityConfigImpl.java 69751e9
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentConfigImpl.java a71c479
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentLauncher.java dfa9ac3
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JServerSocketFactory.java 649038e
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImpl.java 844a775
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionFactoryImpl.java 56449db
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionImpl.java 6ed2912
geode-core/src/main/java/com/gemstone/gemfire/distributed/ConfigurationProperties.java 5c3a282
geode-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java 8795b71
geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 81d874d
geode-core/src/main/java/com/gemstone/gemfire/distributed/SSLEnabledComponents.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java cce482a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java cc544f6
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfig.java 2ff6540
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java fd4743b
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 259f7c2
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java b9566df
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 46d9610
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 7f8eed6
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocation.java 0e7430c
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java f5b774f
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java 9f18e62
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 2d8b8e1
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberFactory.java 4328bed
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSUtil.java d489431
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java 6df0c7b
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 9fdbb64
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java 1065214
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 58b794a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGAddress.java 1f97001
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java a119bb5
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/LocatorCancelException.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpClient.java c770238
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java ceb5af8
geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 4d0c5a8
geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 7a8dccd
geode-core/src/main/java/com/gemstone/gemfire/internal/DistributionLocator.java 2549c7a
geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1
geode-core/src/main/java/com/gemstone/gemfire/internal/MigrationClient.java 2c81e90
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCloser.java 8318afa
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java fded3c3
geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/SSLConfig.java 36c553e
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/DistributionLocatorId.java 1459d89
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/FetchHostResponse.java a9712be
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java 17875bf
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ClusterConfigurationLoader.java e362389
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a7bad
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RedundancyLogger.java f7e8621
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/PersistentMemberPattern.java a0e1f0a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java 7422e16
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 6fd4560
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientUpdater.java 26efd4d
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheServerStats.java 658b35e
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/GatewayReceiverCreation.java e76d39a
geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java 5f9213d
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLEnabledComponent.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCloser.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreator.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreatorFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatHelper.java b52eaae
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatSampler.java d414d2c
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveWriter.java 027bde1
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java a69f878
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/ConnectionTable.java 3a5eb9f
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java a38244c
geode-core/src/main/java/com/gemstone/gemfire/management/GemFireProperties.java 5f09d7d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JettyHelper.java 42dcd64
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerAdvisee.java 3af34e1
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java 861f51d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java f3c771f
geode-core/src/main/java/com/gemstone/gemfire/management/internal/RestAgent.java e835bab
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/BeanUtilFuncs.java b802648
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java 08260d3
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 7b04c06
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 09a25a6
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/JmxOperationInvoker.java a67cae3
geode-core/src/main/java/com/gemstone/gemfire/memcached/GemFireMemcachedServer.java ba0b479
geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java 6f6ae6d
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java fef2171
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 42bd683
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/CacheServerSSLConnectionDUnitTest.java ee5cc62
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/LocatorLoadBalancingDUnitTest.java 1bc2322
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java 3c05794
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationTestCase.java cc13c48
geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java 1be3b9f
geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java 438c3f7
geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherMemberMXBeanIntegrationTest.java 8c570ac
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 954846f
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java af0c30d
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalIntegrationTest.java faf6d31
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteIntegrationTest.java 8e978e9
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalIntegrationTest.java 1baf48d
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteIntegrationTest.java 6d20673
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionConfigJUnitTest.java 6d6f36d
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java a59262e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/StartupMessageDataJUnitTest.java 6aa4248
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/MembershipJUnitTest.java 9c7180e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/NetViewJUnitTest.java fbc4189
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java d29553c
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocatorRecoveryJUnitTest.java fcf77a0
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerBackwardCompatDUnitTest.java 954aff4
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitTest.java 425b391
geode-core/src/test/java/com/gemstone/gemfire/internal/AbstractConfigJUnitTest.java 400f872
geode-core/src/test/java/com/gemstone/gemfire/internal/JSSESocketJUnitTest.java d0d906a
geode-core/src/test/java/com/gemstone/gemfire/internal/SSLConfigJUnitTest.java c8addf8
geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserJUnitTest.java cc71738
geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserWithWaitJUnitTest.java 0ba41ba
geode-core/src/test/java/com/gemstone/gemfire/internal/net/JSSESocketJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactoryTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserWithWaitJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCreatorFactoryJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/GemFireStatSamplerIntegrationTest.java ff7c34d
geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/SimpleStatSamplerIntegrationTest.java d86b968
geode-core/src/test/java/com/gemstone/gemfire/internal/tcp/ConnectionJUnitTest.java 3a88707
geode-core/src/test/java/com/gemstone/gemfire/management/CacheManagementDUnitTest.java 550a6cb
geode-core/src/test/java/com/gemstone/gemfire/management/JMXMBeanDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 91a6188
geode-core/src/test/java/com/gemstone/gemfire/management/internal/JettyHelperJUnitTest.java 1c66780
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 5720955
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 21cdfbc
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java 6f70e57
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 32cea6a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 7a96adf
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 2691e09
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java 86c61b6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 87a7ab9
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationDUnitTest.java 3c17f9f
geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java c591732
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NetworkUtils.java dec882e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java 686779d
geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb87797
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/excludedClasses.txt ddacf99
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 03288c2
geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKey.jks PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKeyTrust.jks PRE-CREATION
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/testbed/driver/PulseUITest.java 24ba815
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java eeaa069
geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorDiscovery.java 0fd206e
geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java 5f4943d
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractRemoteGatewaySender.java d45d5ef
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java 9fd73e6
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java fd2c0b5
geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java bdd5d71
geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java b35dce9
gradle/java.gradle 36d88dc
Diff: https://reviews.apache.org/r/51227/diff/
Testing
-------
precheckin - completed. All green.
regression testing to follow
Thanks,
Udo Kohlmeyer
Re: Review Request 51227: GEODE-420: Locator SSL
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51227/
-----------------------------------------------------------
(Updated Aug. 22, 2016, 1:55 a.m.)
Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
Repository: geode
Description
-------
As per the specification: https://cwiki.apache.org/confluence/display/GEODE/Revised+SSL+properties
* Removal of legacy/deprecate previous ssl-* properties
* Deprecation of current <component>-ssl-* properties
* Moving of SocketCreator and SocketCloser to the com.gemstone.gemfire.internal.net package
* Addition of an ExtendedAliasKeyManager to manage keystores with many keys and aliases
* Addition of locator ssl properties
* Addition of SocketCreatorFactory
* Addition of SSLConfigFactory
* Addition of JMXMBeanDUnitTest
* Addition of SSLEnabledComponent Enum
* Ciphers and Protocols are stored as String[] instead of previous legacy String
* TCPClient is now instance rather than Singleton
Diffs (updated)
-----
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java 3408717
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsQueryAndFEJUnitTest.java 8321caf
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java daa781d
geode-core/src/main/java/com/gemstone/gemfire/admin/DistributedSystemConfig.java 5ef389f
geode-core/src/main/java/com/gemstone/gemfire/admin/GemFireMemberStatus.java 1b544a8
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemConfigImpl.java 517f5a6
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemHealthMonitor.java 54e7de7
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributionLocatorConfigImpl.java 88d939a
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/EnabledManagedEntityController.java ff139c5
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/InetAddressUtil.java 43d8e44
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/ManagedEntityConfigImpl.java 69751e9
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentConfigImpl.java a71c479
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentLauncher.java dfa9ac3
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JServerSocketFactory.java 649038e
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImpl.java 844a775
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionFactoryImpl.java 56449db
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionImpl.java 6ed2912
geode-core/src/main/java/com/gemstone/gemfire/distributed/ConfigurationProperties.java 5c3a282
geode-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java 8795b71
geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 81d874d
geode-core/src/main/java/com/gemstone/gemfire/distributed/SSLEnabledComponents.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java cce482a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java cc544f6
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfig.java 2ff6540
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java fd4743b
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 259f7c2
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 49a4c97
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 46d9610
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 7f8eed6
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/RuntimeDistributionConfigImpl.java c1384c3
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocation.java 0e7430c
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java f5b774f
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java 9f18e62
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 2d8b8e1
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberFactory.java 4328bed
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSUtil.java d489431
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java 6df0c7b
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 9fdbb64
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java 1065214
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 58b794a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGAddress.java 1f97001
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java a119bb5
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/LocatorCancelException.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpClient.java c770238
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java ceb5af8
geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 4d0c5a8
geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 7a8dccd
geode-core/src/main/java/com/gemstone/gemfire/internal/DistributionLocator.java 2549c7a
geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1
geode-core/src/main/java/com/gemstone/gemfire/internal/MigrationClient.java 2c81e90
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCloser.java 8318afa
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java fded3c3
geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/SSLConfig.java 36c553e
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/DistributionLocatorId.java 1459d89
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/FetchHostResponse.java a9712be
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java 17875bf
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ClusterConfigurationLoader.java e362389
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a7bad
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RedundancyLogger.java f7e8621
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/PersistentMemberPattern.java a0e1f0a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java 7422e16
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 6fd4560
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientUpdater.java 26efd4d
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheServerStats.java 658b35e
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/GatewayReceiverCreation.java e76d39a
geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java 443fe78
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLEnabledComponent.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCloser.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreator.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreatorFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatHelper.java b52eaae
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatSampler.java d414d2c
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveWriter.java 027bde1
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java a69f878
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/ConnectionTable.java 3a5eb9f
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java a38244c
geode-core/src/main/java/com/gemstone/gemfire/management/GemFireProperties.java 5f09d7d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JettyHelper.java 42dcd64
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerAdvisee.java 3af34e1
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java 861f51d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java f3c771f
geode-core/src/main/java/com/gemstone/gemfire/management/internal/RestAgent.java e835bab
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/BeanUtilFuncs.java b802648
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java 08260d3
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 7b04c06
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 09a25a6
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/JmxOperationInvoker.java a67cae3
geode-core/src/main/java/com/gemstone/gemfire/memcached/GemFireMemcachedServer.java ba0b479
geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java 6f6ae6d
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java fef2171
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 42bd683
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/CacheServerSSLConnectionDUnitTest.java ee5cc62
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/LocatorLoadBalancingDUnitTest.java 1bc2322
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java 3c05794
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationTestCase.java cc13c48
geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java 1be3b9f
geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java 438c3f7
geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherMemberMXBeanIntegrationTest.java 8c570ac
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 954846f
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java af0c30d
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalIntegrationTest.java faf6d31
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteIntegrationTest.java 8e978e9
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalIntegrationTest.java 1baf48d
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteIntegrationTest.java 6d20673
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionConfigJUnitTest.java 6d6f36d
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java a59262e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/StartupMessageDataJUnitTest.java 6aa4248
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/MembershipJUnitTest.java 9c7180e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/NetViewJUnitTest.java fbc4189
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java d29553c
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocatorRecoveryJUnitTest.java fcf77a0
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerBackwardCompatDUnitTest.java 954aff4
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitTest.java 425b391
geode-core/src/test/java/com/gemstone/gemfire/internal/AbstractConfigJUnitTest.java 400f872
geode-core/src/test/java/com/gemstone/gemfire/internal/JSSESocketJUnitTest.java d0d906a
geode-core/src/test/java/com/gemstone/gemfire/internal/SSLConfigJUnitTest.java c8addf8
geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserJUnitTest.java cc71738
geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserWithWaitJUnitTest.java 0ba41ba
geode-core/src/test/java/com/gemstone/gemfire/internal/net/JSSESocketJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactoryTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserWithWaitJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCreatorFactoryJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/GemFireStatSamplerIntegrationTest.java ff7c34d
geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/SimpleStatSamplerIntegrationTest.java d86b968
geode-core/src/test/java/com/gemstone/gemfire/internal/tcp/ConnectionJUnitTest.java 3a88707
geode-core/src/test/java/com/gemstone/gemfire/management/CacheManagementDUnitTest.java 550a6cb
geode-core/src/test/java/com/gemstone/gemfire/management/JMXMBeanDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 91a6188
geode-core/src/test/java/com/gemstone/gemfire/management/internal/JettyHelperJUnitTest.java 1c66780
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 5720955
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 21cdfbc
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java 6f70e57
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 32cea6a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 7a96adf
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 2691e09
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java 86c61b6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 87a7ab9
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationDUnitTest.java 3c17f9f
geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java c591732
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NetworkUtils.java dec882e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java 686779d
geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb87797
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/excludedClasses.txt ddacf99
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 03288c2
geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKey.jks PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKeyTrust.jks PRE-CREATION
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/testbed/driver/PulseUITest.java 24ba815
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java eeaa069
geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorDiscovery.java 0fd206e
geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java 5f4943d
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractRemoteGatewaySender.java d45d5ef
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java 9fd73e6
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java fd2c0b5
geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java bdd5d71
geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java b35dce9
gradle/java.gradle 36d88dc
Diff: https://reviews.apache.org/r/51227/diff/
Testing
-------
precheckin - completed. All green.
regression testing to follow
Thanks,
Udo Kohlmeyer
Re: Review Request 51227: GEODE-420: Locator SSL
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51227/
-----------------------------------------------------------
(Updated Aug. 22, 2016, 1:42 a.m.)
Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
Repository: geode
Description
-------
As per the specification: https://cwiki.apache.org/confluence/display/GEODE/Revised+SSL+properties
* Removal of legacy/deprecate previous ssl-* properties
* Deprecation of current <component>-ssl-* properties
* Moving of SocketCreator and SocketCloser to the com.gemstone.gemfire.internal.net package
* Addition of an ExtendedAliasKeyManager to manage keystores with many keys and aliases
* Addition of locator ssl properties
* Addition of SocketCreatorFactory
* Addition of SSLConfigFactory
* Addition of JMXMBeanDUnitTest
* Addition of SSLEnabledComponent Enum
* Ciphers and Protocols are stored as String[] instead of previous legacy String
* TCPClient is now instance rather than Singleton
Diffs
-----
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java 3408717
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsQueryAndFEJUnitTest.java 8321caf
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java daa781d
geode-core/src/main/java/com/gemstone/gemfire/admin/DistributedSystemConfig.java 5ef389f
geode-core/src/main/java/com/gemstone/gemfire/admin/GemFireMemberStatus.java 1b544a8
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemConfigImpl.java 517f5a6
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemHealthMonitor.java 54e7de7
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributionLocatorConfigImpl.java 88d939a
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/EnabledManagedEntityController.java ff139c5
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/InetAddressUtil.java 43d8e44
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/ManagedEntityConfigImpl.java 69751e9
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentConfigImpl.java a71c479
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentLauncher.java dfa9ac3
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JServerSocketFactory.java 649038e
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImpl.java 844a775
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionFactoryImpl.java 56449db
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionImpl.java 6ed2912
geode-core/src/main/java/com/gemstone/gemfire/distributed/ConfigurationProperties.java 5c3a282
geode-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java 8795b71
geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 81d874d
geode-core/src/main/java/com/gemstone/gemfire/distributed/SSLEnabledComponents.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java cce482a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java cc544f6
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfig.java 2ff6540
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java fd4743b
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 259f7c2
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 49a4c97
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 46d9610
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 7f8eed6
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/RuntimeDistributionConfigImpl.java c1384c3
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocation.java 0e7430c
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java f5b774f
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java 9f18e62
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 2d8b8e1
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberFactory.java 4328bed
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSUtil.java d489431
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java 6df0c7b
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 9fdbb64
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java 1065214
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 58b794a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGAddress.java 1f97001
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java a119bb5
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/LocatorCancelException.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpClient.java c770238
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java ceb5af8
geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 4d0c5a8
geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 7a8dccd
geode-core/src/main/java/com/gemstone/gemfire/internal/DistributionLocator.java 2549c7a
geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1
geode-core/src/main/java/com/gemstone/gemfire/internal/MigrationClient.java 2c81e90
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCloser.java 8318afa
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java fded3c3
geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/SSLConfig.java 36c553e
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/DistributionLocatorId.java 1459d89
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/FetchHostResponse.java a9712be
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java 17875bf
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ClusterConfigurationLoader.java e362389
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a7bad
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RedundancyLogger.java f7e8621
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/PersistentMemberPattern.java a0e1f0a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java 7422e16
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 6fd4560
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientUpdater.java 26efd4d
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheServerStats.java 658b35e
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/GatewayReceiverCreation.java e76d39a
geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java 443fe78
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLEnabledComponent.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCloser.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreator.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreatorFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatHelper.java b52eaae
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatSampler.java d414d2c
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveWriter.java 027bde1
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java a69f878
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/ConnectionTable.java 3a5eb9f
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java a38244c
geode-core/src/main/java/com/gemstone/gemfire/management/GemFireProperties.java 5f09d7d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JettyHelper.java 42dcd64
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerAdvisee.java 3af34e1
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java 861f51d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java f3c771f
geode-core/src/main/java/com/gemstone/gemfire/management/internal/RestAgent.java e835bab
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/BeanUtilFuncs.java b802648
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java 08260d3
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 7b04c06
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 09a25a6
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/JmxOperationInvoker.java a67cae3
geode-core/src/main/java/com/gemstone/gemfire/memcached/GemFireMemcachedServer.java ba0b479
geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java 6f6ae6d
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java fef2171
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 42bd683
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/CacheServerSSLConnectionDUnitTest.java ee5cc62
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/LocatorLoadBalancingDUnitTest.java 1bc2322
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java 3c05794
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationTestCase.java cc13c48
geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java 1be3b9f
geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java 438c3f7
geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherMemberMXBeanIntegrationTest.java 8c570ac
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 954846f
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java af0c30d
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalIntegrationTest.java faf6d31
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteIntegrationTest.java 8e978e9
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalIntegrationTest.java 1baf48d
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteIntegrationTest.java 6d20673
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionConfigJUnitTest.java 6d6f36d
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java a59262e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/StartupMessageDataJUnitTest.java 6aa4248
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/MembershipJUnitTest.java 9c7180e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/NetViewJUnitTest.java fbc4189
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java d29553c
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocatorRecoveryJUnitTest.java fcf77a0
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerBackwardCompatDUnitTest.java 954aff4
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitTest.java 425b391
geode-core/src/test/java/com/gemstone/gemfire/internal/AbstractConfigJUnitTest.java 400f872
geode-core/src/test/java/com/gemstone/gemfire/internal/JSSESocketJUnitTest.java d0d906a
geode-core/src/test/java/com/gemstone/gemfire/internal/SSLConfigJUnitTest.java c8addf8
geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserJUnitTest.java cc71738
geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserWithWaitJUnitTest.java 0ba41ba
geode-core/src/test/java/com/gemstone/gemfire/internal/net/JSSESocketJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactoryTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserWithWaitJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCreatorFactoryJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/GemFireStatSamplerIntegrationTest.java ff7c34d
geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/SimpleStatSamplerIntegrationTest.java d86b968
geode-core/src/test/java/com/gemstone/gemfire/internal/tcp/ConnectionJUnitTest.java 3a88707
geode-core/src/test/java/com/gemstone/gemfire/management/CacheManagementDUnitTest.java 550a6cb
geode-core/src/test/java/com/gemstone/gemfire/management/JMXMBeanDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 91a6188
geode-core/src/test/java/com/gemstone/gemfire/management/internal/JettyHelperJUnitTest.java 1c66780
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 5720955
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 21cdfbc
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java 6f70e57
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 32cea6a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 7a96adf
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 2691e09
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java 86c61b6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 87a7ab9
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationDUnitTest.java 3c17f9f
geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java c591732
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NetworkUtils.java dec882e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java 686779d
geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb87797
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/excludedClasses.txt ddacf99
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 03288c2
geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKey.jks PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKeyTrust.jks PRE-CREATION
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/testbed/driver/PulseUITest.java 24ba815
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java eeaa069
geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorDiscovery.java 0fd206e
geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java 5f4943d
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractRemoteGatewaySender.java d45d5ef
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java 9fd73e6
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java fd2c0b5
geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java bdd5d71
geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java b35dce9
gradle/java.gradle 36d88dc
Diff: https://reviews.apache.org/r/51227/diff/
Testing (updated)
-------
precheckin - completed. All green.
regression testing to follow
Thanks,
Udo Kohlmeyer
Re: Review Request 51227: GEODE-420: Locator SSL
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51227/
-----------------------------------------------------------
(Updated Aug. 18, 2016, 11:30 p.m.)
Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
Repository: geode
Description (updated)
-------
As per the specification: https://cwiki.apache.org/confluence/display/GEODE/Revised+SSL+properties
* Removal of legacy/deprecate previous ssl-* properties
* Deprecation of current <component>-ssl-* properties
* Moving of SocketCreator and SocketCloser to the com.gemstone.gemfire.internal.net package
* Addition of an ExtendedAliasKeyManager to manage keystores with many keys and aliases
* Addition of locator ssl properties
* Addition of SocketCreatorFactory
* Addition of SSLConfigFactory
* Addition of JMXMBeanDUnitTest
* Addition of SSLEnabledComponent Enum
* Ciphers and Protocols are stored as String[] instead of previous legacy String
* TCPClient is now instance rather than Singleton
Diffs
-----
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java 3408717
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsQueryAndFEJUnitTest.java 8321caf
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java daa781d
geode-core/src/main/java/com/gemstone/gemfire/admin/DistributedSystemConfig.java 5ef389f
geode-core/src/main/java/com/gemstone/gemfire/admin/GemFireMemberStatus.java 1b544a8
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemConfigImpl.java 517f5a6
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemHealthMonitor.java 54e7de7
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributionLocatorConfigImpl.java 88d939a
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/EnabledManagedEntityController.java ff139c5
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/InetAddressUtil.java 43d8e44
geode-core/src/main/java/com/gemstone/gemfire/admin/internal/ManagedEntityConfigImpl.java 69751e9
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentConfigImpl.java a71c479
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/AgentLauncher.java dfa9ac3
geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JServerSocketFactory.java 649038e
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImpl.java 844a775
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionFactoryImpl.java 56449db
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionImpl.java 6ed2912
geode-core/src/main/java/com/gemstone/gemfire/distributed/ConfigurationProperties.java 5c3a282
geode-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java 8795b71
geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 81d874d
geode-core/src/main/java/com/gemstone/gemfire/distributed/SSLEnabledComponents.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java cce482a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java cc544f6
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfig.java 2ff6540
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java fd4743b
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 259f7c2
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 49a4c97
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 46d9610
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 7f8eed6
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/RuntimeDistributionConfigImpl.java c1384c3
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocation.java 0e7430c
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java f5b774f
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java 9f18e62
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 2d8b8e1
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberFactory.java 4328bed
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSUtil.java d489431
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java 6df0c7b
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 9fdbb64
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java 1065214
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 58b794a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGAddress.java 1f97001
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java a119bb5
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/LocatorCancelException.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpClient.java c770238
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java ceb5af8
geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 4d0c5a8
geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 7a8dccd
geode-core/src/main/java/com/gemstone/gemfire/internal/DistributionLocator.java 2549c7a
geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1
geode-core/src/main/java/com/gemstone/gemfire/internal/MigrationClient.java 2c81e90
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCloser.java 8318afa
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java fded3c3
geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/SSLConfig.java 36c553e
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/DistributionLocatorId.java 1459d89
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/FetchHostResponse.java a9712be
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java 17875bf
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ClusterConfigurationLoader.java e362389
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a7bad
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RedundancyLogger.java f7e8621
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/PersistentMemberPattern.java a0e1f0a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java 7422e16
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 6fd4560
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientUpdater.java 26efd4d
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheServerStats.java 658b35e
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/GatewayReceiverCreation.java e76d39a
geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java 443fe78
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLEnabledComponent.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCloser.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreator.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreatorFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatHelper.java b52eaae
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatSampler.java d414d2c
geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveWriter.java 027bde1
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java a69f878
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/ConnectionTable.java 3a5eb9f
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java a38244c
geode-core/src/main/java/com/gemstone/gemfire/management/GemFireProperties.java 5f09d7d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JettyHelper.java 42dcd64
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerAdvisee.java 3af34e1
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java 861f51d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java f3c771f
geode-core/src/main/java/com/gemstone/gemfire/management/internal/RestAgent.java e835bab
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/BeanUtilFuncs.java b802648
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java 08260d3
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 7b04c06
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 09a25a6
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/JmxOperationInvoker.java a67cae3
geode-core/src/main/java/com/gemstone/gemfire/memcached/GemFireMemcachedServer.java ba0b479
geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java 6f6ae6d
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java fef2171
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 42bd683
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/CacheServerSSLConnectionDUnitTest.java ee5cc62
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/LocatorLoadBalancingDUnitTest.java 1bc2322
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java 3c05794
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationTestCase.java cc13c48
geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java 1be3b9f
geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java 438c3f7
geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherMemberMXBeanIntegrationTest.java 8c570ac
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 954846f
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java af0c30d
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalIntegrationTest.java faf6d31
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteIntegrationTest.java 8e978e9
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalIntegrationTest.java 1baf48d
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteIntegrationTest.java 6d20673
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionConfigJUnitTest.java 6d6f36d
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java a59262e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/StartupMessageDataJUnitTest.java 6aa4248
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/MembershipJUnitTest.java 9c7180e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/NetViewJUnitTest.java fbc4189
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java d29553c
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocatorRecoveryJUnitTest.java fcf77a0
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerBackwardCompatDUnitTest.java 954aff4
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitTest.java 425b391
geode-core/src/test/java/com/gemstone/gemfire/internal/AbstractConfigJUnitTest.java 400f872
geode-core/src/test/java/com/gemstone/gemfire/internal/JSSESocketJUnitTest.java d0d906a
geode-core/src/test/java/com/gemstone/gemfire/internal/SSLConfigJUnitTest.java c8addf8
geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserJUnitTest.java cc71738
geode-core/src/test/java/com/gemstone/gemfire/internal/SocketCloserWithWaitJUnitTest.java 0ba41ba
geode-core/src/test/java/com/gemstone/gemfire/internal/net/JSSESocketJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactoryTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCloserWithWaitJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCreatorFactoryJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/GemFireStatSamplerIntegrationTest.java ff7c34d
geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/SimpleStatSamplerIntegrationTest.java d86b968
geode-core/src/test/java/com/gemstone/gemfire/internal/tcp/ConnectionJUnitTest.java 3a88707
geode-core/src/test/java/com/gemstone/gemfire/management/CacheManagementDUnitTest.java 550a6cb
geode-core/src/test/java/com/gemstone/gemfire/management/JMXMBeanDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 91a6188
geode-core/src/test/java/com/gemstone/gemfire/management/internal/JettyHelperJUnitTest.java 1c66780
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 5720955
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 21cdfbc
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java 6f70e57
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 32cea6a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 7a96adf
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 2691e09
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java 86c61b6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 87a7ab9
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationDUnitTest.java 3c17f9f
geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java c591732
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NetworkUtils.java dec882e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java 686779d
geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb87797
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/excludedClasses.txt ddacf99
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 03288c2
geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKey.jks PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/internal/net/multiKeyTrust.jks PRE-CREATION
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/testbed/driver/PulseUITest.java 24ba815
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java eeaa069
geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorDiscovery.java 0fd206e
geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java 5f4943d
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractRemoteGatewaySender.java d45d5ef
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java 9fd73e6
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java fd2c0b5
geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java bdd5d71
geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java b35dce9
gradle/java.gradle 36d88dc
Diff: https://reviews.apache.org/r/51227/diff/
Testing (updated)
-------
precheckin
regression testing to follow
Thanks,
Udo Kohlmeyer