[GitHub] [spark] cloud-fan commented on a change in pull request #31320: [SPARK-34223][SQL] FIX NPE for static partition with null in InsertIntoHadoopFsRelationCommand

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31320:
URL: https://github.com/apache/spark/pull/31320#discussion_r563876176



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala
##########
@@ -200,6 +200,14 @@ trait SQLInsertTestSuite extends QueryTest with SQLTestUtils {
         e1.getMessage.contains(v2Msg))
     }
   }
+
+  test("SPARK-34223: static partition with null raise NPE") {

Review comment:
       This test fails in `DSV2SQLInsertTestSuite` due to another bug in ds v2.
   
   Can we put this test in `SQLQuerySuite` for easy backport? We can fix the ds v2 bug and move back the test to here later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org