You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/17 15:39:21 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

jorisvandenbossche commented on a change in pull request #10118:
URL: https://github.com/apache/arrow/pull/10118#discussion_r633637602



##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -393,6 +393,11 @@ cdef class Dataset(_Weakrefable):
         use_threads : bool, default True
             If enabled, then maximum parallelism will be used determined by
             the number of available CPU cores.
+        use_async : bool, default False
+            If enabled, the an async scanner will be used that should offer

Review comment:
       ```suggestion
               If enabled, an async scanner will be used that should offer
   ```

##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -2721,6 +2727,10 @@ cdef class Scanner(_Weakrefable):
     use_threads : bool, default True
         If enabled, then maximum parallelism will be used determined by
         the number of available CPU cores.
+    use_async : bool, default False
+        If enabled, the an async scanner will be used that should offer

Review comment:
       ```suggestion
           If enabled, an async scanner will be used that should offer
   ```

##########
File path: python/pyarrow/dataset.py
##########
@@ -725,6 +725,10 @@ def write_dataset(data, base_dir, basename_template=None, format=None,
     use_threads : bool, default True
         Write files in parallel. If enabled, then maximum parallelism will be
         used determined by the number of available CPU cores.
+    use_async : bool, default False
+        If enabled, the an async scanner will be used that should offer

Review comment:
       ```suggestion
           If enabled, an async scanner will be used that should offer
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org