You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/03/31 15:46:18 UTC
[GitHub] [commons-vfs] garydgregory commented on a change in pull request
#44: More efficient comparison in FileExtensionSelector
garydgregory commented on a change in pull request #44: More efficient comparison in FileExtensionSelector
URL: https://github.com/apache/commons-vfs/pull/44#discussion_r270672247
##########
File path: commons-vfs2/src/main/java/org/apache/commons/vfs2/FileExtensionSelector.java
##########
@@ -47,7 +47,11 @@
*/
public FileExtensionSelector(final Collection<String> extensions) {
if (extensions != null) {
- this.extensions.addAll(extensions);
+ for (String ext : extensions) {
+ if (ext != null) {
Review comment:
+1 to the null check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services