You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by te...@apache.org on 2019/03/18 14:18:57 UTC

[hadoop] branch trunk updated: HDFS-14328. [Clean-up] Remove NULL check before instanceof in TestGSet (Contributed by Shweta Yakkali via Daniel Templeton)

This is an automated email from the ASF dual-hosted git repository.

templedf pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 2db38ab  HDFS-14328. [Clean-up] Remove NULL check before instanceof in TestGSet (Contributed by Shweta Yakkali via Daniel Templeton)
2db38ab is described below

commit 2db38abffcd89bf1fa0cad953254daea7e4e415b
Author: Shweta Yakkali <sh...@cloudera.com>
AuthorDate: Mon Mar 18 15:10:26 2019 +0100

    HDFS-14328. [Clean-up] Remove NULL check before instanceof in TestGSet
    (Contributed by Shweta Yakkali via Daniel Templeton)
    
    Change-Id: I5b9f0e66664714d7c5bbfa30492a09f770626711
---
 .../hadoop-common/src/test/java/org/apache/hadoop/util/TestGSet.java   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGSet.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGSet.java
index 2d39f3d..14dde6a 100644
--- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGSet.java
+++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGSet.java
@@ -23,7 +23,6 @@ import java.util.Iterator;
 import java.util.Random;
 
 import org.apache.hadoop.HadoopIllegalArgumentException;
-import org.apache.hadoop.util.Time;
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -471,7 +470,7 @@ public class TestGSet {
 
     @Override
     public boolean equals(Object obj) {
-      return obj != null && obj instanceof IntElement
+      return obj instanceof IntElement
           && value == ((IntElement)obj).value;
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org