[jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins

["Anton Mushin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817549#comment-15817549 ] 

Anton Mushin commented on FLINK-5256:
-------------------------------------

Thanks for your comment!
I update my [test branch|https://github.com/apache/flink/compare/master...ex00:FLINK-5256-tests], could you look it please?
I have suspect that next line is not exactly correct
{code:title=DataSetSingleRowJoin.scala#176}
s"${conversion.resultTerm}.setField($i,null);")
{code}
What do you think about this changes?

bq.2) the MapJoinLeftRunner and MapJoinRightRunner: Right now both runners do only call the join function if the single input is set (not null). For outer joins we also need to produce output if the single input is null.

How can I test this case? I tried test it in [this case|https://github.com/apache/flink/compare/master...ex00:FLINK-5256-tests#diff-102e5d9e330260c0acf5e4e54ff3bdceR438]. This case is passing now.

> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
>                 Key: FLINK-5256
>                 URL: https://issues.apache.org/jira/browse/FLINK-5256
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Anton Mushin
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and right joins with single input. These cases can be handled if the  {{DataSetSingleRowJoin}} is extended to support outer joins on the non-single-row input, i.e., left joins if the right side is single input and vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)