[GitHub] QiuMM commented on a change in pull request #6847: Coordinator await initialization before finishing startup

[GitBox <gi...@apache.org>]

QiuMM commented on a change in pull request #6847: Coordinator await initialization before finishing startup
URL: https://github.com/apache/incubator-druid/pull/6847#discussion_r256678640
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/HttpServerInventoryView.java
 ##########
 @@ -132,7 +129,7 @@ public HttpServerInventoryView(
 
 
   @LifecycleStart
-  public void start() throws Exception
+  public void start() throws ISE
 
 Review comment:
   It may be thrown, here is the code:
   ```java
   if (!lifecycleLock.canStart()) {
           throw new ISE("can't start.");
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org