You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by ya...@apache.org on 2022/10/26 02:00:18 UTC
[doris] branch master updated: [improvement](config) allow to modify the master-only configuration of non-master nodes (#13558)
This is an automated email from the ASF dual-hosted git repository.
yangzhg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new e385cb063c [improvement](config) allow to modify the master-only configuration of non-master nodes (#13558)
e385cb063c is described below
commit e385cb063c659a9a1fa495def00295f0b3fd363b
Author: luozenglin <37...@users.noreply.github.com>
AuthorDate: Wed Oct 26 10:00:12 2022 +0800
[improvement](config) allow to modify the master-only configuration of non-master nodes (#13558)
Non-master nodes may switch to master, so we should allow the master-only configuration of all fe nodes to be modified.
---
fe/fe-core/src/main/java/org/apache/doris/common/ConfigBase.java | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/common/ConfigBase.java b/fe/fe-core/src/main/java/org/apache/doris/common/ConfigBase.java
index b15ee9efcc..0c8adc572e 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/common/ConfigBase.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/common/ConfigBase.java
@@ -17,8 +17,6 @@
package org.apache.doris.common;
-import org.apache.doris.catalog.Env;
-
import com.google.common.base.Strings;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
@@ -312,9 +310,6 @@ public class ConfigBase {
if (!anno.mutable()) {
throw new DdlException("Config '" + key + "' is not mutable");
}
- if (anno.masterOnly() && !Env.getCurrentEnv().isMaster()) {
- throw new DdlException("Config '" + key + "' is master only");
- }
try {
anno.callback().newInstance().handle(field, value);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org