You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/03/21 18:25:51 UTC
[Impala-ASF-CR] IMPALA-12013: Remove future from pkg resources.py
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19641
Change subject: IMPALA-12013: Remove future from pkg_resources.py
......................................................................
IMPALA-12013: Remove future from pkg_resources.py
Removes import future from pkg_resources.py as this file is fairly old
and only used with Python 2. Adding unicode_literals broke reading files
in the HOME directory during package load via pkg_resources when any of
those files contain special characters (above ASCII 127).
Testing:
- added a file with an em dash to the HOME directory, then run
impala-shell with Python 2.7 and without setuptools installed. This
reproduced the issue before adding this patch, and is fixed by this
patch.
Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
---
M shell/pkg_resources.py
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/19641/1
--
To view, visit http://gerrit.cloudera.org:8080/19641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12013: Remove future from pkg resources.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19641 )
Change subject: IMPALA-12013: Remove future from pkg_resources.py
......................................................................
IMPALA-12013: Remove future from pkg_resources.py
Removes import future from pkg_resources.py as this file is fairly old
and only used with Python 2. Adding unicode_literals in IMPALA-3343 /
IMPALA-9489 broke reading files in the HOME directory during package
load via pkg_resources when any of those files contain special
characters (above ASCII 127).
Testing:
- added a file with an em dash to the HOME directory, then run
impala-shell with Python 2.7 and without setuptools installed. This
reproduced the issue before adding this patch, and is fixed by this
patch.
Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Reviewed-on: http://gerrit.cloudera.org:8080/19641
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M shell/pkg_resources.py
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12013: Remove future from pkg resources.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19641 )
Change subject: IMPALA-12013: Remove future from pkg_resources.py
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
This makes sense to me
http://gerrit.cloudera.org:8080/#/c/19641/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19641/1//COMMIT_MSG@10
PS1, Line 10: Adding unicode_literals broke reading files
: in the HOME directory during package load via pkg_resources when any of
: those files contain special characters (above ASCII 127).
Can you add a sentence saying that this line was added by us in IMPALA-3343/IMPALA-9489 and was not present in the original pkg_resources.py?
(I see we added it here: https://github.com/apache/impala/commit/bc9d7e063dd71f9af75967f8c6af9ac1a6f49149 )
--
To view, visit http://gerrit.cloudera.org:8080/19641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 19:01:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12013: Remove future from pkg resources.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19641 )
Change subject: IMPALA-12013: Remove future from pkg_resources.py
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 19:21:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12013: Remove future from pkg resources.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19641
to look at the new patch set (#2).
Change subject: IMPALA-12013: Remove future from pkg_resources.py
......................................................................
IMPALA-12013: Remove future from pkg_resources.py
Removes import future from pkg_resources.py as this file is fairly old
and only used with Python 2. Adding unicode_literals in IMPALA-3343 /
IMPALA-9489 broke reading files in the HOME directory during package
load via pkg_resources when any of those files contain special
characters (above ASCII 127).
Testing:
- added a file with an em dash to the HOME directory, then run
impala-shell with Python 2.7 and without setuptools installed. This
reproduced the issue before adding this patch, and is fixed by this
patch.
Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
---
M shell/pkg_resources.py
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/19641/2
--
To view, visit http://gerrit.cloudera.org:8080/19641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12013: Remove future from pkg resources.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19641 )
Change subject: IMPALA-12013: Remove future from pkg_resources.py
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9163/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 18:39:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12013: Remove future from pkg resources.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19641 )
Change subject: IMPALA-12013: Remove future from pkg_resources.py
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 23:54:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12013: Remove future from pkg resources.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19641 )
Change subject: IMPALA-12013: Remove future from pkg_resources.py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12659/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 18:46:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12013: Remove future from pkg resources.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19641 )
Change subject: IMPALA-12013: Remove future from pkg_resources.py
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19641/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19641/1//COMMIT_MSG@10
PS1, Line 10: Adding unicode_literals broke reading files
: in the HOME directory during package load via pkg_resources when any of
: those files contain special characters (above ASCII 127).
> Can you add a sentence saying that this line was added by us in IMPALA-3343
Yup, meant to do that and forgot.
--
To view, visit http://gerrit.cloudera.org:8080/19641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 19:05:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12013: Remove future from pkg resources.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19641 )
Change subject: IMPALA-12013: Remove future from pkg_resources.py
......................................................................
Patch Set 2: Verified+1
Carrying verified for commit message change.
--
To view, visit http://gerrit.cloudera.org:8080/19641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Mar 2023 14:46:27 +0000
Gerrit-HasComments: No