[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5544: Add SCALAR type into TransformFunctionType

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544#discussion_r439567697



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java
##########
@@ -70,6 +73,9 @@ public static TransformFunctionType getTransformFunctionType(String functionName
     try {
       return TransformFunctionType.valueOf(upperCaseFunctionName);
     } catch (Exception e) {
+      if (FunctionRegistry.getFunctionByName(functionName) != null) {

Review comment:
       @siddharthteotia Updated the doc, and also added a TODO to merge FunctionRegistry and FunctionDefinitionRegistry to provide one single registry for all functions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org