[GitHub] [airflow] potiuk edited a comment on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module

[GitBox <gi...@apache.org>]

potiuk edited a comment on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
URL: https://github.com/apache/airflow/pull/6938#issuecomment-569427788
 
 
   @ash @kaxil @mik-laj -> @nuclearpinguin hit those cyclic imports when fixing pylint issues (and I helped a bit to unentangle it). It would be great if you take a look as well I think.
   
   One comment - I think it's great example when you see pylint cyclic imports detection is actually useful. 
   
   It shows this kind of places where things are accidentally coupled in the same module but are really  from different levels of abstractions/should be separated out. 
   In this example - there is really little motivation to keep  @provide_session and resetdb() (for example) in the same module - especially if you see that provide_session is USED by models and resetdb USES models - that's where the cyclic import came from.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services