You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Andrew McGeachie (JIRA)" <ji...@apache.org> on 2009/10/27 21:26:59 UTC

[jira] Created: (THRIFT-614) More informative exception when THTTPClient gets an unexpected response

More informative exception when THTTPClient gets an unexpected response
-----------------------------------------------------------------------

                 Key: THRIFT-614
                 URL: https://issues.apache.org/jira/browse/THRIFT-614
             Project: Thrift
          Issue Type: Improvement
            Reporter: Andrew McGeachie
            Priority: Trivial
         Attachments: thrift-614.patch

Currently, THTTPClient can only handle an NSHTTPURLResponse.  For anything else it throws an exception:


 {code}
  if (![response isKindOfClass: [NSHTTPURLResponse class]]) {
     @throw [TTransportException exceptionWithName: @"TTransportException"
                                           reason: @"Unexpected NSURLResponse type"];
{code}

It would be nice if the exception included the actual NSURLResponse object that was encountered, to aid debugging.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-614) More informative exception when THTTPClient gets an unexpected response

Posted by "Andrew McGeachie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew McGeachie updated THRIFT-614:
------------------------------------

    Attachment: thrift-614.patch

The patch.

> More informative exception when THTTPClient gets an unexpected response
> -----------------------------------------------------------------------
>
>                 Key: THRIFT-614
>                 URL: https://issues.apache.org/jira/browse/THRIFT-614
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Andrew McGeachie
>            Priority: Trivial
>         Attachments: thrift-614.patch
>
>
> Currently, THTTPClient can only handle an NSHTTPURLResponse.  For anything else it throws an exception:
>  {code}
>   if (![response isKindOfClass: [NSHTTPURLResponse class]]) {
>      @throw [TTransportException exceptionWithName: @"TTransportException"
>                                            reason: @"Unexpected NSURLResponse type"];
> {code}
> It would be nice if the exception included the actual NSURLResponse object that was encountered, to aid debugging.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-614) More informative exception when THTTPClient gets an unexpected response

Posted by "Andrew McGeachie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew McGeachie resolved THRIFT-614.
-------------------------------------

    Resolution: Fixed

Patch applied.

> More informative exception when THTTPClient gets an unexpected response
> -----------------------------------------------------------------------
>
>                 Key: THRIFT-614
>                 URL: https://issues.apache.org/jira/browse/THRIFT-614
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Andrew McGeachie
>            Priority: Trivial
>         Attachments: thrift-614.patch
>
>
> Currently, THTTPClient can only handle an NSHTTPURLResponse.  For anything else it throws an exception:
>  {code}
>   if (![response isKindOfClass: [NSHTTPURLResponse class]]) {
>      @throw [TTransportException exceptionWithName: @"TTransportException"
>                                            reason: @"Unexpected NSURLResponse type"];
> {code}
> It would be nice if the exception included the actual NSURLResponse object that was encountered, to aid debugging.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.