You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2018/12/06 12:05:27 UTC

[GitHub] nifi-minifi-cpp pull request #456: MINIFICPP-690: Correct log statement and ...

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/456

    MINIFICPP-690: Correct log statement and regenerate docs

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-690

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #456
    
----
commit 3bd7eb12e5b05a4cd8df7f0f92aef44c0c1ad4d3
Author: Marc Parisi <ph...@...>
Date:   2018-12-06T12:04:59Z

    MINIFICPP-690: Correct log statement and regenerate docs

----


---

[GitHub] nifi-minifi-cpp pull request #456: MINIFICPP-690: Correct log statement and ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/456


---

[GitHub] nifi-minifi-cpp issue #456: MINIFICPP-690: Correct log statement and regener...

Posted by apiri <gi...@git.apache.org>.

Github user apiri commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/456
  
    reviewing


---