You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/02/21 19:40:00 UTC
[jira] [Commented] (IMPALA-7181) Fix flaky test
shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening
[ https://issues.apache.org/jira/browse/IMPALA-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774447#comment-16774447 ]
ASF subversion and git services commented on IMPALA-7181:
---------------------------------------------------------
Commit 5cd0c5ddf53d2f3d0283e03b7e7769b84995e1de in impala's branch refs/heads/2.x from Vincent Tran
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5cd0c5d ]
IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening
test_shell_commandline.py::TestImpalaShell::test_socket_opening
uses netcat to listen to an ephemeral port to verify the expected
socket opening behavior of impala-shell.
This port number is fixed to 42000. When this port happens to
be used by another outbound socket, this test will fail.
This change refactors the test to use socket.bind(). The port used
in this test is no longer fixed and will be picked automatically.
This change also adds the proper cleanup logics to the various
subprocess.Popen objects used in the test.
Change-Id: Idd64632ded936d49fc404bcac75588dd7886be44
Reviewed-on: http://gerrit.cloudera.org:8080/10747
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening
> -------------------------------------------------------------------------------------
>
> Key: IMPALA-7181
> URL: https://issues.apache.org/jira/browse/IMPALA-7181
> Project: IMPALA
> Issue Type: Bug
> Affects Versions: Impala 2.13.0, Impala 3.1.0
> Reporter: Vincent Tran
> Assignee: Vincent Tran
> Priority: Blocker
> Labels: broken-build
> Fix For: Impala 2.13.0, Impala 3.1.0
>
>
> shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening uses netcat to listen to an ephemeral port to verify impala-shell socket opening behavior.
> The port is hardcoded to 42000 which can fail the test if this port is used by an outgoing socket.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org