You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/04 01:16:20 UTC
[GitHub] [lucene-solr] erikhatcher opened a new pull request #1827: SOLR-14792: Remove VelocityResponseWriter
erikhatcher opened a new pull request #1827:
URL: https://github.com/apache/lucene-solr/pull/1827
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Remove VelocityResponseWriter and its references and usages.
# Solution
Removed contrib/velocity and all related uses.
# Tests
Will ensured all Solr tests, precommit, and smoketesters pass.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on pull request #1827: SOLR-14792: Remove VelocityResponseWriter
Posted by GitBox <gi...@apache.org>.
arafalov commented on pull request #1827:
URL: https://github.com/apache/lucene-solr/pull/1827#issuecomment-687685130
Reviewing leftover references:
The /browse is still mentioned in the following files:
- example/files/README.txt (actually that is broken even in released Solr)
- solr/solr-ref-guide/src/solr-tutorial.adoc
- solr/solr-ref-guide/src/initparams-in-solrconfig.adoc
- solr/solr-ref-guide/src/rule-based-authorization-plugin.adoc
Looks ok otherwise, apart from accidentally check-ins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on pull request #1827: SOLR-14792: Remove VelocityResponseWriter
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1827:
URL: https://github.com/apache/lucene-solr/pull/1827#issuecomment-687060583
@erikhatcher BTW, the .adoc format renders nicely in Github if you were to pull the ref guide docs over to https://github.com/erikhatcher/solritas. We could also update the link in the solr.cool entry to point directly to them, instead of the general github README page ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] erikhatcher commented on pull request #1827: SOLR-14792: Remove VelocityResponseWriter
Posted by GitBox <gi...@apache.org>.
erikhatcher commented on pull request #1827:
URL: https://github.com/apache/lucene-solr/pull/1827#issuecomment-687232685
> @erikhatcher BTW, the .adoc format renders nicely in Github if you were to pull the ref guide docs over to https://github.com/erikhatcher/solritas. We could also update the link in the solr.cool entry to point directly to them, instead of the general github README page ;-)
Thanks for that tip! I'll definitely be pulling the docs over and adjusting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] chatman commented on a change in pull request #1827: SOLR-14792: Remove VelocityResponseWriter
Posted by GitBox <gi...@apache.org>.
chatman commented on a change in pull request #1827:
URL: https://github.com/apache/lucene-solr/pull/1827#discussion_r483335351
##########
File path: solr/example/files/conf/lang/stemdict_nl.txt
##########
@@ -1,6 +0,0 @@
-# Set of overrides for the dutch stemmer
-# TODO: load this as a resource from the analyzer and sync it in build.xml
-fiets fiets
Review comment:
Are these stemdict files velocity specific?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1827: SOLR-14792: Remove VelocityResponseWriter
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1827:
URL: https://github.com/apache/lucene-solr/pull/1827#issuecomment-687245022
BTW the more up do date https://github.com/erikhatcher/solritas is in the next few days, the better as I'll be doing a recorded Activate session on this September 10th with a demo of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org