You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/24 13:28:52 UTC

[GitHub] [arrow] raulcd commented on a diff in pull request #13216: ARROW-16018: [Doc][Python] Run doctests on Python docstring examples (CI job)

raulcd commented on code in PR #13216:
URL: https://github.com/apache/arrow/pull/13216#discussion_r880506701


##########
docker-compose.yml:
##########
@@ -1055,12 +1055,14 @@ services:
       LANG: "C.UTF-8"
       BUILD_DOCS_CPP: "ON"
       BUILD_DOCS_PYTHON: "ON"
+      PYTEST_ARGS: "--doctest-modules --doctest-cython"
     volumes: *conda-volumes
     command:
       ["/arrow/ci/scripts/cpp_build.sh /arrow /build &&
         /arrow/ci/scripts/python_build.sh /arrow /build &&
         pip install -e /arrow/dev/archery[numpydoc] &&
-        archery numpydoc --allow-rule PR01,PR10"]
+        archery numpydoc --allow-rule PR01,PR10

Review Comment:
   I think the `&&` will be required to be treated as two different commands. Otherwise both lines will be treated as a single command:
   ```suggestion
           archery numpydoc --allow-rule PR01,PR10 &&
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org