You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "HTHou (via GitHub)" <gi...@apache.org> on 2023/06/09 03:58:17 UTC

[GitHub] [iotdb] HTHou opened a new pull request, #10096: Fix reconnect logic of python client

HTHou opened a new pull request, #10096:
URL: https://github.com/apache/iotdb/pull/10096

   ## Description
   
   The reconnect method was copied from Java version, but there are some logic bugs in Python Client, which are caused by the following reasons.
   
   1. The for loop of Python is different with Java. 
   For example, `for i in range(0, 5)` in Python not equals to `for (int i = 0; i < 5; i++)` in Java. When `i` was set to `-1` in the loop, the loop would break in Python but not in Java.
   
   2. The random method is different between Python and Java. `random.randint(0, a)` in Python means getting a number in range [0, a]. However, in Java `random.nextInt(a)` means getting a number in range [0, a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou merged pull request #10096: Fix reconnect logic of python client

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #10096:
URL: https://github.com/apache/iotdb/pull/10096


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org