[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #31884: remove 'wait_for_completion' from ecs register/deregister operators

["utkarsharma2 (via GitHub)" <gi...@apache.org>]

utkarsharma2 commented on code in PR #31884:
URL: https://github.com/apache/airflow/pull/31884#discussion_r1229125242


##########
airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -215,40 +212,22 @@ def __init__(
         self,
         *,
         task_definition: str,
-        wait_for_completion: bool = True,
-        waiter_delay: int | None = None,
-        waiter_max_attempts: int | None = None,
+        wait_for_completion: bool = True,  # obsolete

Review Comment:
   Should we also add a warning saying `wait_for_completion/waiter_delay/waiter_max_attempts` has no effect going forward and point to the documentation in AWS? And also, a deprecation warning assuming they will eventually be removed would be nice. WDYT?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org