[jira] [Commented] (HBASE-11556) Move HTablePool to hbase-thrift module.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069101#comment-14069101 ] 

Hadoop QA commented on HBASE-11556:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12656915/hbase-11556.patch
  against trunk revision .
  ATTACHMENT ID: 12656915

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    + * Once you are done with it, close your instance of {@link org.apache.hadoop.hbase.client.HTableInterface}
+ * by calling {@link org.apache.hadoop.hbase.client.HTableInterface#close()} rather than returning the tables
+     * {@link #batchCallback(List, Object[], org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)}
+        throw new IllegalStateException("Table=" + new String(table.getTableName()) + " already closed");
+@Suite.SuiteClasses({TestHTablePool.TestHTableReusablePool.class, TestHTablePool.TestHTableThreadLocalPool.class})

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.hfile.TestCacheConfig

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10136//console

This message is automatically generated.

> Move HTablePool to hbase-thrift module.
> ---------------------------------------
>
>                 Key: HBASE-11556
>                 URL: https://issues.apache.org/jira/browse/HBASE-11556
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>    Affects Versions: 2.0.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 2.0.0
>
>         Attachments: hbase-11556.patch
>
>
> Thrift2 is the only place in the core hbase project where HTablePool is used.  HTablePool is currently marked deprecated since 0.98.1 and users have been discouraged from using it for a while.  
> This patch moves HTablePool to the hbase-thrift module so that we remove it from the core client api and group it with the piece of code it is used by.
> We got here because HBASE-11554 attempted to remove what seemed to Reusable pooltype, and it ended up that thrift2 defaulted to this Reusable type.



--
This message was sent by Atlassian JIRA
(v6.2#6252)