You are viewing a plain text version of this content. The canonical link for it is here.
Posted to svn@forrest.apache.org by rg...@apache.org on 2005/01/19 00:23:27 UTC
svn commit: r125565 - /forrest/trunk/tools/eclipse/src/org/apache/forrest/eclipse/job/ForrestRunner.java
Author: rgardler
Date: Tue Jan 18 15:23:21 2005
New Revision: 125565
URL: http://svn.apache.org/viewcvs?view=rev&rev=125565
Log:
add a refactor note
Modified:
forrest/trunk/tools/eclipse/src/org/apache/forrest/eclipse/job/ForrestRunner.java
Modified: forrest/trunk/tools/eclipse/src/org/apache/forrest/eclipse/job/ForrestRunner.java
Url: http://svn.apache.org/viewcvs/forrest/trunk/tools/eclipse/src/org/apache/forrest/eclipse/job/ForrestRunner.java?view=diff&rev=125565&p1=forrest/trunk/tools/eclipse/src/org/apache/forrest/eclipse/job/ForrestRunner.java&r1=125564&p2=forrest/trunk/tools/eclipse/src/org/apache/forrest/eclipse/job/ForrestRunner.java&r2=125565
==============================================================================
--- forrest/trunk/tools/eclipse/src/org/apache/forrest/eclipse/job/ForrestRunner.java (original)
+++ forrest/trunk/tools/eclipse/src/org/apache/forrest/eclipse/job/ForrestRunner.java Tue Jan 18 15:23:21 2005
@@ -52,6 +52,8 @@
private static final int EXCEPTION_UNABLE_TO_START = 2010;
+ private String workingDir;
+
/**
* Create a Forrest runner that will run a Jetty server on a given directory
* @param workingDir - the working directory for the command
@@ -64,6 +66,7 @@
/* Run the Forrest server in a separate thread and return that thread to the Forrest manager.
* @see java.lang.Runnable#run()
+ * @refactor lots of potential to tidy up this code, for example extract a few methods, move relevant code to ForrestManager
*/
public IStatus run(IProgressMonitor monitor) {
if (logger.isDebugEnabled()) {