You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/20 15:26:35 UTC

[GitHub] [ozone] symious commented on a diff in pull request #3701: HDDS-7155. Create interface between SCM and DN

symious commented on code in PR #3701:
URL: https://github.com/apache/ozone/pull/3701#discussion_r950707846


##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -453,14 +453,14 @@ message ContainerBalancerConfigurationProto {
 }
 
 message DiskBalancerConfigurationProto {
-    optional double threshold = 1;
-    optional double diskBandwidth = 2;
+    optional string threshold = 1;

Review Comment:
   @ChenSammi Currently ConfigurationReflectionUtil can not detect the type of "Double", so I revert the type back to string, please have a look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org