You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/08 14:58:30 UTC

[GitHub] [spark] srowen commented on a change in pull request #26796: [SPARK-30164][Tests][Doc] SBT clean before document generation

srowen commented on a change in pull request #26796: [SPARK-30164][Tests][Doc] SBT clean before document generation
URL: https://github.com/apache/spark/pull/26796#discussion_r355192178
 
 

 ##########
 File path: docs/README.md
 ##########
 @@ -83,7 +83,7 @@ $ PRODUCTION=1 jekyll build
 
 ## API Docs (Scaladoc, Javadoc, Sphinx, roxygen2, MkDocs)
 
-You can build just the Spark scaladoc and javadoc by running `./build/sbt unidoc` from the `$SPARK_HOME` directory.
+You can build just the Spark scaladoc and javadoc by running `./build/sbt clean unidoc` from the `$SPARK_HOME` directory.
 
 Review comment:
   I can imagine adding this to the docs, as users might have stale compiled code locally or something. How often would it occur in run-tests? In PR builders it starts with a clean build and I'd guess users recompile before tests. I'm also worried about slowdown for the PR builders.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org