You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2025/06/06 19:25:56 UTC
[PR] Bound seek range using families in iter stack [accumulo]
keith-turner opened a new pull request, #5621:
URL: https://github.com/apache/accumulo/pull/5621
When using scanner or batch scanner and setting a range+column on the scanner Range.bound will be called by the scanner to narrow the range. However when seeking in an iterator on the server side, nothing similar is done. Added this narrowing to ColumnFamilySkippingIterator which will cause any server side iterator seeks to be narrowed using Range.bound().
Manually did some test to ensure nothing in the code was currently doing this. Added some prints to the rfile code and had server side iterators seek with a range over an entire row w/ some column families. Did not see any narrowing happen w/o this change. Wanted to make sure it was not being done by code somewhere in the iter stack that did not call Range.bound().
Without this change a seek with a range that covers an entire row and a set of column families will always go to the first key in the row and start skipping from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bound seek range using families in iter stack [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5621:
URL: https://github.com/apache/accumulo/pull/5621#issuecomment-2956158206
Ok. I was thinking that if the narrowing was done in an earlier release, and we lost it somewhere, then we would want to highlight that in the release notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bound seek range using families in iter stack [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5621:
URL: https://github.com/apache/accumulo/pull/5621#issuecomment-2955560168
I'm assuming that server-side seeks to a specified column family used to work in earlier versions (1.10, 2.0, etc.), right? I would be shocked if this is not the case. I'm curious when this stopped working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bound seek range using families in iter stack [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #5621:
URL: https://github.com/apache/accumulo/pull/5621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bound seek range using families in iter stack [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5621:
URL: https://github.com/apache/accumulo/pull/5621#issuecomment-2958820217
@keith-turner - it looks like `BigRootTabletIT.test` started failing after this was merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bound seek range using families in iter stack [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #5621:
URL: https://github.com/apache/accumulo/pull/5621#issuecomment-2959562606
> @keith-turner - it looks like BigRootTabletIT.test started failing after this was merged.
Seems there is an existing bug in Range.bound(), looking into fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bound seek range using families in iter stack [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #5621:
URL: https://github.com/apache/accumulo/pull/5621#issuecomment-2956150117
> I'm assuming that server-side seeks to a specified column family used to work in earlier versions (1.10, 2.0, etc.), right? I would be shocked if this is not the case. I'm curious when this stopped working.
The seek works before this change, the following code will skip the unwanted data, it is just not as efficient as it could be if the range were narrowed. Not sure if this narrowing was ever done, but did not look at the history of this class in detail.
https://github.com/apache/accumulo/blob/33b9becf11788f5fd032cad179bd07e4509f32a2/core/src/main/java/org/apache/accumulo/core/iteratorsImpl/system/ColumnFamilySkippingIterator.java#L62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org