You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/08/02 09:48:32 UTC

Review Request 13231: Updated README.md.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13231/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Brenden Matthews, and Vinod Kone.


Repository: mesos-git


Description
-------

FYI, this README has some yet to be committed features.


Diffs
-----

  hadoop/README.md d5a99f6f649e468f18255323f4f7fb5d8613bca8 

Diff: https://reviews.apache.org/r/13231/diff/


Testing
-------


Thanks,

Benjamin Hindman


Re: Review Request 13231: Updated README.md.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Aug. 2, 2013, 4:48 p.m., Vinod Kone wrote:
> > hadoop/README.md, lines 81-100
> > <https://reviews.apache.org/r/13231/diff/1/?file=334401#file334401line81>
> >
> >     what about all the other mesos specific properties that we have in mapred-site.xml e.g. minimum map slots, slot allocation policy?
> >     
> >     maybe we should provide a mapred-site.xml in this repo?
> >     
> >

I'm going to ask Brenden to add these into the README as well.


> On Aug. 2, 2013, 4:48 p.m., Vinod Kone wrote:
> > hadoop/README.md, line 109
> > <https://reviews.apache.org/r/13231/diff/1/?file=334401#file334401line109>
> >
> >     just to be explicit, can you say
> >     
> >     Linux:
> >     $ MESOS_NATIVE_LIBRARY=/path/to/libmesos.so hadoop jobtracker
> >     
> >     OSX:
> >     $ MESOS_NATIVE_LIBRARY=/path/to/libmesos.dylib hadoop jobtracker
> >

Sure!


> On Aug. 2, 2013, 4:48 p.m., Vinod Kone wrote:
> > hadoop/README.md, line 53
> > <https://reviews.apache.org/r/13231/diff/1/?file=334401#file334401line53>
> >
> >     s/your distribution/Hadoop on Mesos distribution/ ?

Yes, thanks!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13231/#review24536
-----------------------------------------------------------


On Aug. 2, 2013, 7:48 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13231/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 7:48 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Brenden Matthews, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> FYI, this README has some yet to be committed features.
> 
> 
> Diffs
> -----
> 
>   hadoop/README.md d5a99f6f649e468f18255323f4f7fb5d8613bca8 
> 
> Diff: https://reviews.apache.org/r/13231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 13231: Updated README.md.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13231/#review24536
-----------------------------------------------------------



hadoop/README.md
<https://reviews.apache.org/r/13231/#comment48546>

    s/your distribution/Hadoop on Mesos distribution/ ?



hadoop/README.md
<https://reviews.apache.org/r/13231/#comment48549>

    what about all the other mesos specific properties that we have in mapred-site.xml e.g. minimum map slots, slot allocation policy?
    
    maybe we should provide a mapred-site.xml in this repo?
    
    



hadoop/README.md
<https://reviews.apache.org/r/13231/#comment48551>

    just to be explicit, can you say
    
    Linux:
    $ MESOS_NATIVE_LIBRARY=/path/to/libmesos.so hadoop jobtracker
    
    OSX:
    $ MESOS_NATIVE_LIBRARY=/path/to/libmesos.dylib hadoop jobtracker
    


- Vinod Kone


On Aug. 2, 2013, 7:48 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13231/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 7:48 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Brenden Matthews, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> FYI, this README has some yet to be committed features.
> 
> 
> Diffs
> -----
> 
>   hadoop/README.md d5a99f6f649e468f18255323f4f7fb5d8613bca8 
> 
> Diff: https://reviews.apache.org/r/13231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 13231: Updated README.md.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13231/
-----------------------------------------------------------

(Updated Aug. 6, 2013, 7:01 p.m.)


Review request for mesos, Ben Mahler, Brenden Matthews, and Vinod Kone.


Bugs: MESOS-618
    https://issues.apache.org/jira/browse/MESOS-618


Repository: mesos-git


Description
-------

FYI, this README has some yet to be committed features.


Diffs
-----

  hadoop/README.md d5a99f6f649e468f18255323f4f7fb5d8613bca8 

Diff: https://reviews.apache.org/r/13231/diff/


Testing
-------


Thanks,

Benjamin Hindman


Re: Review Request 13231: Updated README.md.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13231/#review24575
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Aug. 2, 2013, 7:48 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13231/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 7:48 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Brenden Matthews, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> FYI, this README has some yet to be committed features.
> 
> 
> Diffs
> -----
> 
>   hadoop/README.md d5a99f6f649e468f18255323f4f7fb5d8613bca8 
> 
> Diff: https://reviews.apache.org/r/13231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>