[GitHub] incubator-zeppelin pull request: Add dockerfile (and makefile) to ...

[bzz <gi...@git.apache.org>]

Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/175#issuecomment-139987266
  
    Sorry for by late reply, having a default Docker image for Zeppelin is a great idea, couple of things though:
    
     - I think that `MAINTAINER` field should either be something like Zeppelin Project (incubating), or in case you are willing to volunteer to take care of it and leave as it is, may be this should be discussed on dev@ mailing list first, to let others know and get a consensus 
    
     - it might be a good idea to expose "~/.m2" repository in Dockerfile as `VOLUME` and advise users in comment at the top of the file to mount it before building an image (as you do in Makefile)
    
     - generally it's a good practice to have a comment, at the top of the file, with explanation of what it is for, how to build it and how to use it
    
        ```sh
    # Build: 
    #   `make install-local` default
    #    `....` spark 1.5, hadoop 2.2
    # Usage:
    #   docker run .... \
    #       ....  <path-to>/bin/zeppelin.sh
    #
    #   NOTE: you may want to use /root/.m2 volume to save time downloading dependencies
        ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---