You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/03/22 13:47:17 UTC
[GitHub] [singa-doc] nudles opened a new pull request #5: Update some
documentation files
nudles opened a new pull request #5: Update some documentation files
URL: https://github.com/apache/singa-doc/pull/5
1. for the git workflow
2. team list
3. release steps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] FeynmanDNA commented on a change in pull request #5:
Update some documentation files
Posted by GitBox <gi...@apache.org>.
FeynmanDNA commented on a change in pull request #5: Update some documentation files
URL: https://github.com/apache/singa-doc/pull/5#discussion_r396099285
##########
File path: docs-site/docs/contribute-code.md
##########
@@ -18,120 +18,70 @@ A simple way to enforce the Google coding styles is to use the linting and forma
Once the extensions are installed, edit the `settings.json` file.
-```json
+```json
{
- "[cpp]": {
- "editor.defaultFormatter": "xaver.clang-format"
- },
- "cpplint.cpplintPath": "path/to/cpplint",
-
- "editor.formatOnSave": true,
- "python.formatting.provider": "yapf",
- "python.linting.enabled": true,
- "python.linting.lintOnSave": true,
- "clang-format.language.cpp.style": "google",
- "python.formatting.yapfArgs" : ["--style" , "{based_on_style: google}" ]
+ "[cpp]": {
+ "editor.defaultFormatter": "xaver.clang-format"
+ },
+ "cpplint.cpplintPath": "path/to/cpplint",
+
+ "editor.formatOnSave": true,
+ "python.formatting.provider": "yapf",
+ "python.linting.enabled": true,
+ "python.linting.lintOnSave": true,
+ "clang-format.language.cpp.style": "google",
+ "python.formatting.yapfArgs": ["--style", "{based_on_style: google}"]
}
```
Depending on your platform, the user settings file is located here:
+
1. Windows %APPDATA%\Code\User\settings.json
-2. macOS $HOME/Library/Application Support/Code/User/settings.json
-3. Linux $HOME/.config/Code/User/settings.json
+2. macOS \$HOME/Library/Application Support/Code/User/settings.json
Review comment:
probably this is due to the linting and formatting, maybe you can try wrap these paths in ticks
2. macOS `$HOME/Library/Application Support/Code/User/settings.json`
3. Linux `$HOME/.config/Code/User/settings.json`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] nudles commented on issue #5: Update some documentation
files
Posted by GitBox <gi...@apache.org>.
nudles commented on issue #5: Update some documentation files
URL: https://github.com/apache/singa-doc/pull/5#issuecomment-602204137
@FeynmanDNA do we need to fix the node, yarn and Docusaurus version?
```yarn start:website``` didn't work for me.
```yarn start``` worked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] nudles merged pull request #5: Update some
documentation files
Posted by GitBox <gi...@apache.org>.
nudles merged pull request #5: Update some documentation files
URL: https://github.com/apache/singa-doc/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] nudles commented on a change in pull request #5: Update
some documentation files
Posted by GitBox <gi...@apache.org>.
nudles commented on a change in pull request #5: Update some documentation files
URL: https://github.com/apache/singa-doc/pull/5#discussion_r396095771
##########
File path: docs-site/docs/contribute-code.md
##########
@@ -18,120 +18,70 @@ A simple way to enforce the Google coding styles is to use the linting and forma
Once the extensions are installed, edit the `settings.json` file.
-```json
+```json
{
- "[cpp]": {
- "editor.defaultFormatter": "xaver.clang-format"
- },
- "cpplint.cpplintPath": "path/to/cpplint",
-
- "editor.formatOnSave": true,
- "python.formatting.provider": "yapf",
- "python.linting.enabled": true,
- "python.linting.lintOnSave": true,
- "clang-format.language.cpp.style": "google",
- "python.formatting.yapfArgs" : ["--style" , "{based_on_style: google}" ]
+ "[cpp]": {
+ "editor.defaultFormatter": "xaver.clang-format"
+ },
+ "cpplint.cpplintPath": "path/to/cpplint",
+
+ "editor.formatOnSave": true,
+ "python.formatting.provider": "yapf",
+ "python.linting.enabled": true,
+ "python.linting.lintOnSave": true,
+ "clang-format.language.cpp.style": "google",
+ "python.formatting.yapfArgs": ["--style", "{based_on_style: google}"]
}
```
Depending on your platform, the user settings file is located here:
+
1. Windows %APPDATA%\Code\User\settings.json
-2. macOS $HOME/Library/Application Support/Code/User/settings.json
-3. Linux $HOME/.config/Code/User/settings.json
+2. macOS \$HOME/Library/Application Support/Code/User/settings.json
Review comment:
@FeynmanDNA does the git hook add the `\` automatically? I removed it manually; but after committing, it came back again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] FeynmanDNA commented on a change in pull request #5:
Update some documentation files
Posted by GitBox <gi...@apache.org>.
FeynmanDNA commented on a change in pull request #5: Update some documentation files
URL: https://github.com/apache/singa-doc/pull/5#discussion_r396099455
##########
File path: docs-site/docs/contribute-code.md
##########
@@ -18,120 +18,70 @@ A simple way to enforce the Google coding styles is to use the linting and forma
Once the extensions are installed, edit the `settings.json` file.
-```json
+```json
{
- "[cpp]": {
- "editor.defaultFormatter": "xaver.clang-format"
- },
- "cpplint.cpplintPath": "path/to/cpplint",
-
- "editor.formatOnSave": true,
- "python.formatting.provider": "yapf",
- "python.linting.enabled": true,
- "python.linting.lintOnSave": true,
- "clang-format.language.cpp.style": "google",
- "python.formatting.yapfArgs" : ["--style" , "{based_on_style: google}" ]
+ "[cpp]": {
Review comment:
usually, JS files are indenting with 2 spaces
https://github.com/apache/singa-doc/blob/0f8de13fe9decc307fbb8205397edc7650e26017/docs-site/.prettierrc#L7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] FeynmanDNA commented on issue #5: Update some
documentation files
Posted by GitBox <gi...@apache.org>.
FeynmanDNA commented on issue #5: Update some documentation files
URL: https://github.com/apache/singa-doc/pull/5#issuecomment-602209567
> @FeynmanDNA do we need to fix the node, yarn and Docusaurus version?
> `yarn start:website` didn't work for me.
> `yarn start` worked.
if you are at this repo's root, `yarn run start:website` is actually running this
https://github.com/apache/singa-doc/blob/0f8de13fe9decc307fbb8205397edc7650e26017/docs-site/package.json#L54
`yarn start` might work if you are inside the website subdir `docs-site/website`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] nudles commented on a change in pull request #5: Update
some documentation files
Posted by GitBox <gi...@apache.org>.
nudles commented on a change in pull request #5: Update some documentation files
URL: https://github.com/apache/singa-doc/pull/5#discussion_r396095906
##########
File path: docs-site/docs/contribute-code.md
##########
@@ -18,120 +18,70 @@ A simple way to enforce the Google coding styles is to use the linting and forma
Once the extensions are installed, edit the `settings.json` file.
-```json
+```json
{
- "[cpp]": {
- "editor.defaultFormatter": "xaver.clang-format"
- },
- "cpplint.cpplintPath": "path/to/cpplint",
-
- "editor.formatOnSave": true,
- "python.formatting.provider": "yapf",
- "python.linting.enabled": true,
- "python.linting.lintOnSave": true,
- "clang-format.language.cpp.style": "google",
- "python.formatting.yapfArgs" : ["--style" , "{based_on_style: google}" ]
+ "[cpp]": {
Review comment:
how many spaces should be added for indent in Docusaurus? 3 or 4?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services