[jira] [Closed] (FLINK-16753) Exception from AsyncCheckpointRunnable should be wrapped in CheckpointException

["Zhijiang (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhijiang closed FLINK-16753.
----------------------------
    Resolution: Fixed

Merged in master: a1b1dc95210e99e6c23069415283fce4ec3793a5

> Exception from AsyncCheckpointRunnable should be wrapped in CheckpointException
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-16753
>                 URL: https://issues.apache.org/jira/browse/FLINK-16753
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Checkpointing
>    Affects Versions: 1.10.0, 1.11.0, 1.11.1
>            Reporter: Jiayi Liao
>            Assignee: Jiayi Liao
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.12.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> If an exception is thrown from task's async checkpoint process, the checkpoint will be declined as expected, but the reason for declining checkpoint will be regarded as {{CheckpointFailureReason.JOB_FAILURE}}, which gives a wrong message to users.
> I think we can simply replace
> {code:java}
> owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(), checkpointException);
> {code}
> with
>  
> {code:java}
> owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(), new CheckpointException(CheckpointFailureReason.EXCEPTION, checkpointException));
> {code}
> in {{AsyncCheckpointRunnable.handleExecutionException}}.
> cc [~trohrmann]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)