You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/02/01 19:52:45 UTC
[GitHub] [hive] hsnusonic commented on a change in pull request #2954: HIVE-25875: Hive support for Multi-authentication types (SAML and LDAP)
hsnusonic commented on a change in pull request #2954:
URL: https://github.com/apache/hive/pull/2954#discussion_r796941624
##########
File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java
##########
@@ -214,9 +214,13 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
}
} else if (HiveSamlUtils.isSamlAuthMode(authType)) {
Review comment:
If `authType` contains `"KERBEROS"`, then this condition block will never be executed. Was the plan to support kerberos and SAML in the same time?
##########
File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java
##########
@@ -214,9 +214,13 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
}
} else if (HiveSamlUtils.isSamlAuthMode(authType)) {
// check if this request needs a SAML redirect
- if (needsRedirect(request, response)) {
+ String authHeader = request.getHeader(HttpAuthUtils.AUTHORIZATION);
+ if ((authHeader == null || authHeader.isEmpty()) && needsRedirect(request, response)) {
doSamlRedirect(request, response);
return;
+ } else if(authHeader.toLowerCase().startsWith(HttpAuthUtils.BASIC.toLowerCase())) {
+ //LDAP Authentication if the header starts with Basic
+ clientUserName = doPasswdAuth(request, HiveAuthConstants.AuthTypes.NONE.toString());
Review comment:
Do we need to handle the case that `HIVE_SERVER2_TRUSTED_PROXY_TRUSTHEADER` is present?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org