You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by "John Kaputin (JIRA)" <ji...@apache.org> on 2008/08/04 15:54:44 UTC
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619517#action_12619517 ]
John Kaputin commented on WODEN-211:
------------------------------------
I had to make a small code change to get the new woden source tree to compile in Eclipse. The declared package for the 2 converter classes was org.apache.woden.tool.converter, but under the new woden-tool/src/main/java directory the actual package name has been changed to org.apache.woden.converter (i.e. 'tool' has been dropped). I changed the declared package in these 2 classes to match. If this package name change was intentional, I can commit my change to the woden211/trunk branch and/or upload a patch.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
Re: [jira] Commented: (WODEN-211) Refactor directory layout to be more Maven compliant
Posted by "John Kaputin (gmail)" <ja...@gmail.com>.
Jeff,
I would prefer to keep the change to the converter package name (from
org.apache.woden.tool.converter to org.apache.woden.converter), as the new
directory structure eliminates the need to use 'tool' as a package
qualifier. I assume the maven build will create a woden-tool.jar file.
However, we will need to warn the Woden community of this change before
committing to trunk. I'd like to hear what other woden developers think.
regards,
John.
On Tue, Aug 5, 2008 at 3:21 PM, Jeff MAURY <je...@jeffmaury.com> wrote:
> I was my mistake. My intent was to not modify the code and packages
> structure so if it happened, it should be reverted to the old package unless
> the woden community agrees to do so.
>
> Jeff MAURY
>
>
> On Tue, Aug 5, 2008 at 2:27 AM, John Kaputin (gmail) <ja...@gmail.com>wrote:
>
>> I noticed that the package names for the 2 tools (converter and
>> wsdl-viewer) use different styles:
>>
>> The converter package name under the java folder is
>> org.apache.woden.converter (it used to be org.apache.woden.tool.converter)
>> The wsdl-viewer directory structure under the css and javascript folders
>> is org/apache/woden/tool/wsdl-viewer.
>>
>> I don't mind dropping 'tool' from the package or directory path, as both
>> tools are now located under woden-tool, but should we make it consistent and
>> drop 'tool' from the wsdl-viewer directory structure too?
>>
>> Also, is there a way to group the files under woden-tool to make it
>> clearer whether they are for the converter or wsdl-viewer, without breaking
>> Maven compliance? At the moment all tools files are grouped by file type
>> (css, java, javascript, xslt) and you need to look into the sub-directory
>> structure or at the actual file names to work out which tool.
>>
>> regards,
>> John.
>>
>>
>> On Mon, Aug 4, 2008 at 9:54 PM, John Kaputin (JIRA) <ji...@apache.org>wrote:
>>
>>>
>>> [
>>> https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619517#action_12619517]
>>>
>>> John Kaputin commented on WODEN-211:
>>> ------------------------------------
>>>
>>> I had to make a small code change to get the new woden source tree to
>>> compile in Eclipse. The declared package for the 2 converter classes was
>>> org.apache.woden.tool.converter, but under the new woden-tool/src/main/java
>>> directory the actual package name has been changed to
>>> org.apache.woden.converter (i.e. 'tool' has been dropped). I changed the
>>> declared package in these 2 classes to match. If this package name change
>>> was intentional, I can commit my change to the woden211/trunk branch and/or
>>> upload a patch.
>>>
>>> > Refactor directory layout to be more Maven compliant
>>> > ----------------------------------------------------
>>> >
>>> > Key: WODEN-211
>>> > URL: https://issues.apache.org/jira/browse/WODEN-211
>>> > Project: Woden
>>> > Issue Type: Improvement
>>> > Reporter: Jeff MAURY
>>> > Assignee: Jeremy Hughes
>>> > Priority: Minor
>>> > Attachments: trunk.zip
>>> >
>>> >
>>> > The directory layout should be refactored in order to follow Maven
>>> conventions. Today, there are dependencies between the Woden modules which
>>> miss flexibility.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
>>> For additional commands, e-mail: woden-dev-help@ws.apache.org
>>>
>>>
>>
>
>
> --
> La mélancolie c'est communiste
> Tout le monde y a droit de temps en temps
> La mélancolie n'est pas capitaliste
> C'est même gratuit pour les perdants
> La mélancolie c'est pacifiste
> On ne lui rentre jamais dedans
> La mélancolie oh tu sais ça existe
> Elle se prend même avec des gants
> La mélancolie c'est pour les syndicalistes
> Il faut juste sa carte de permanent
>
> Miossec (2006)
>
> http://www.jeffmaury.com
> http://riadiscuss.jeffmaury.com
> http://www.lastfm.fr/listen/user/jeffmaury/personal
> Mes CDs à récupérer:
> http://spreadsheets.google.com/ccc?key=pNeg4Doa_oCsh7CepKPaPTA&hl=en
>
Re: [jira] Commented: (WODEN-211) Refactor directory layout to be more Maven compliant
Posted by Jeff MAURY <je...@jeffmaury.com>.
I was my mistake. My intent was to not modify the code and packages
structure so if it happened, it should be reverted to the old package unless
the woden community agrees to do so.
Jeff MAURY
On Tue, Aug 5, 2008 at 2:27 AM, John Kaputin (gmail) <ja...@gmail.com>wrote:
> I noticed that the package names for the 2 tools (converter and
> wsdl-viewer) use different styles:
>
> The converter package name under the java folder is
> org.apache.woden.converter (it used to be org.apache.woden.tool.converter)
> The wsdl-viewer directory structure under the css and javascript folders is
> org/apache/woden/tool/wsdl-viewer.
>
> I don't mind dropping 'tool' from the package or directory path, as both
> tools are now located under woden-tool, but should we make it consistent and
> drop 'tool' from the wsdl-viewer directory structure too?
>
> Also, is there a way to group the files under woden-tool to make it clearer
> whether they are for the converter or wsdl-viewer, without breaking Maven
> compliance? At the moment all tools files are grouped by file type (css,
> java, javascript, xslt) and you need to look into the sub-directory
> structure or at the actual file names to work out which tool.
>
> regards,
> John.
>
>
> On Mon, Aug 4, 2008 at 9:54 PM, John Kaputin (JIRA) <ji...@apache.org>wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619517#action_12619517]
>>
>> John Kaputin commented on WODEN-211:
>> ------------------------------------
>>
>> I had to make a small code change to get the new woden source tree to
>> compile in Eclipse. The declared package for the 2 converter classes was
>> org.apache.woden.tool.converter, but under the new woden-tool/src/main/java
>> directory the actual package name has been changed to
>> org.apache.woden.converter (i.e. 'tool' has been dropped). I changed the
>> declared package in these 2 classes to match. If this package name change
>> was intentional, I can commit my change to the woden211/trunk branch and/or
>> upload a patch.
>>
>> > Refactor directory layout to be more Maven compliant
>> > ----------------------------------------------------
>> >
>> > Key: WODEN-211
>> > URL: https://issues.apache.org/jira/browse/WODEN-211
>> > Project: Woden
>> > Issue Type: Improvement
>> > Reporter: Jeff MAURY
>> > Assignee: Jeremy Hughes
>> > Priority: Minor
>> > Attachments: trunk.zip
>> >
>> >
>> > The directory layout should be refactored in order to follow Maven
>> conventions. Today, there are dependencies between the Woden modules which
>> miss flexibility.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: woden-dev-help@ws.apache.org
>>
>>
>
--
La mélancolie c'est communiste
Tout le monde y a droit de temps en temps
La mélancolie n'est pas capitaliste
C'est même gratuit pour les perdants
La mélancolie c'est pacifiste
On ne lui rentre jamais dedans
La mélancolie oh tu sais ça existe
Elle se prend même avec des gants
La mélancolie c'est pour les syndicalistes
Il faut juste sa carte de permanent
Miossec (2006)
http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.lastfm.fr/listen/user/jeffmaury/personal
Mes CDs à récupérer:
http://spreadsheets.google.com/ccc?key=pNeg4Doa_oCsh7CepKPaPTA&hl=en
Re: [jira] Commented: (WODEN-211) Refactor directory layout to be more Maven compliant
Posted by "John Kaputin (gmail)" <ja...@gmail.com>.
I noticed that the package names for the 2 tools (converter and wsdl-viewer)
use different styles:
The converter package name under the java folder is
org.apache.woden.converter (it used to be org.apache.woden.tool.converter)
The wsdl-viewer directory structure under the css and javascript folders is
org/apache/woden/tool/wsdl-viewer.
I don't mind dropping 'tool' from the package or directory path, as both
tools are now located under woden-tool, but should we make it consistent and
drop 'tool' from the wsdl-viewer directory structure too?
Also, is there a way to group the files under woden-tool to make it clearer
whether they are for the converter or wsdl-viewer, without breaking Maven
compliance? At the moment all tools files are grouped by file type (css,
java, javascript, xslt) and you need to look into the sub-directory
structure or at the actual file names to work out which tool.
regards,
John.
On Mon, Aug 4, 2008 at 9:54 PM, John Kaputin (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619517#action_12619517]
>
> John Kaputin commented on WODEN-211:
> ------------------------------------
>
> I had to make a small code change to get the new woden source tree to
> compile in Eclipse. The declared package for the 2 converter classes was
> org.apache.woden.tool.converter, but under the new woden-tool/src/main/java
> directory the actual package name has been changed to
> org.apache.woden.converter (i.e. 'tool' has been dropped). I changed the
> declared package in these 2 classes to match. If this package name change
> was intentional, I can commit my change to the woden211/trunk branch and/or
> upload a patch.
>
> > Refactor directory layout to be more Maven compliant
> > ----------------------------------------------------
> >
> > Key: WODEN-211
> > URL: https://issues.apache.org/jira/browse/WODEN-211
> > Project: Woden
> > Issue Type: Improvement
> > Reporter: Jeff MAURY
> > Assignee: Jeremy Hughes
> > Priority: Minor
> > Attachments: trunk.zip
> >
> >
> > The directory layout should be refactored in order to follow Maven
> conventions. Today, there are dependencies between the Woden modules which
> miss flexibility.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: woden-dev-help@ws.apache.org
>
>