[GitHub] [spark] ajithme commented on a change in pull request #24100: [SPARK-27164] RDD.countApprox on empty RDDs schedules jobs which never complete

[GitBox <gi...@apache.org>]

ajithme commented on a change in pull request #24100: [SPARK-27164] RDD.countApprox on empty RDDs schedules jobs which never complete
URL: https://github.com/apache/spark/pull/24100#discussion_r265913510
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
 ##########
 @@ -1239,6 +1239,9 @@ private[spark] class DAGScheduler(
           markMapStageJobsAsFinished(stage)
         case stage : ResultStage =>
           logDebug(s"Stage ${stage} is actually done; (partitions: ${stage.numPartitions})")
 
 Review comment:
   This condition is guarded by a check when ``ResultStage`` itself has zero tasks to run. So it would be skipped for normal jobs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org