You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by re...@apache.org on 2014/10/20 19:28:59 UTC
[07/11] git commit: STREAMS-191 | Removed commented out code that was
in for refactoring purposes.
STREAMS-191 | Removed commented out code that was in for refactoring purposes.
Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/fd3ffe81
Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/fd3ffe81
Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/fd3ffe81
Branch: refs/heads/master
Commit: fd3ffe81cb4595f1c62d8a6e2e69dbe26db8ded9
Parents: 91a0f9a
Author: Ryan Ebanks <ry...@gmail.com>
Authored: Wed Oct 8 14:21:35 2014 -0500
Committer: Ryan Ebanks <ry...@gmail.com>
Committed: Wed Oct 8 14:21:35 2014 -0500
----------------------------------------------------------------------
.../local/tasks/StreamsPersistWriterTask.java | 23 ---------------
.../local/tasks/StreamsProcessorTask.java | 30 --------------------
2 files changed, 53 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/fd3ffe81/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsPersistWriterTask.java
----------------------------------------------------------------------
diff --git a/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsPersistWriterTask.java b/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsPersistWriterTask.java
index 42b32e4..cab46b8 100644
--- a/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsPersistWriterTask.java
+++ b/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsPersistWriterTask.java
@@ -124,29 +124,6 @@ public class StreamsPersistWriterTask extends BaseStreamsTask implements DatumSt
LOGGER.debug("Received null StreamsDatum @ writer : {}", this.writer.getClass().getName());
}
}
-// StreamsDatum datum = this.inQueue.poll();
-// while(this.keepRunning.get()) {
-// if(datum != null) {
-// try {
-// this.writer.write(datum);
-// statusCounter.incrementStatus(DatumStatus.SUCCESS);
-// } catch (Exception e) {
-// LOGGER.error("Error writing to persist writer {}", this.writer.getClass().getSimpleName(), e);
-// this.keepRunning.set(false);
-// statusCounter.incrementStatus(DatumStatus.FAIL);
-// DatumUtils.addErrorToMetadata(datum, e, this.writer.getClass());
-// }
-// }
-// else {
-// try {
-// Thread.sleep(this.sleepTime);
-// } catch (InterruptedException e) {
-// LOGGER.warn("Thread interrupted in Writer task for {}",this.writer.getClass().getSimpleName(), e);
-// this.keepRunning.set(false);
-// }
-// }
-// datum = this.inQueue.poll();
-// }
} catch(Exception e) {
LOGGER.error("Failed to execute Persist Writer {}",this.writer.getClass().getSimpleName(), e);
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/fd3ffe81/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProcessorTask.java
----------------------------------------------------------------------
diff --git a/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProcessorTask.java b/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProcessorTask.java
index a3d367f..ee69127 100644
--- a/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProcessorTask.java
+++ b/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProcessorTask.java
@@ -139,36 +139,6 @@ public class StreamsProcessorTask extends BaseStreamsTask implements DatumStatus
LOGGER.debug("Removed NULL datum from queue at processor : {}", this.processor.getClass().getName());
}
}
-
-// this.processor.prepare(this.streamConfig);
-// StreamsDatum datum = this.inQueue.poll();
-// while(this.keepRunning.get()) {
-// if(datum != null) {
-// try {
-// List<StreamsDatum> output = this.processor.process(datum);
-// if(output != null) {
-// for(StreamsDatum outDatum : output) {
-// super.addToOutgoingQueue(outDatum);
-// statusCounter.incrementStatus(DatumStatus.SUCCESS);
-// }
-// }
-// } catch (Throwable e) {
-// LOGGER.error("Throwable Streams Processor {}", e);
-// statusCounter.incrementStatus(DatumStatus.FAIL);
-// //Add the error to the metadata, but keep processing
-// DatumUtils.addErrorToMetadata(datum, e, this.processor.getClass());
-// }
-// }
-// else {
-// try {
-// Thread.sleep(this.sleepTime);
-// } catch (InterruptedException e) {
-// this.keepRunning.set(false);
-// }
-// }
-// datum = this.inQueue.poll();
-// }
-
} finally {
this.isRunning.set(false);
this.processor.cleanUp();